GDC Intern
Creative thinking
1x
2 Issues Created
2x
16 Issues Created
3x
128 Issues Created
4x
1024 Issues Created
Problem Solving
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Practical/Professional Skills
Communication Skills
1x
100th Community Interaction
2x
1000th Community Interaction
3x
10000th Community Interaction
Collaboration
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Community Engagement
1x
100 Activity Points
2x
1000 Activity Points
3x
10000 Activity Points
Leadership
1x
Promoted to a team leader
Learn How to Learn
1x
Completed the course work
Skills to apply digital & technology solutions
1x
1 Project Completed Successfully
2x
2 Projects Completed Successfully
3x
3 Projects Completed Successfully
Critical Thinking
Autonomy And Responsibility
1x
2 issues identified and resolved
2x
16 issues identified and resolved
3x
128 issues identified and resolved
4x
1024 issues identified and resolved
Empathy
Value inculcation
Multicultural Competence
Individual Skills
Creative thinking
Problem Solving
Practical/Professional Skills
Team Skills
Communication Skills
Collaboration
Community Engagement
Leadership
Learn How to Learn
Skills to apply digital & technology solutions
Critical Thinking
Advanced Skills
Autonomy And Responsibility
Empathy
Value inculcation
Multicultural Competence
Cultural Skills
7 in last 7 days
7 in last 7 days
0 in last 7 days
care_fe/6863
Update GitHub action versionscare/1773
Data Migration to Support New Discharge Reason Fieldcare/1760
Add Telemedicine as a rounds type optioncare_fe/6831
Add Telemedicine as a rounds type optioncare_fe/6807
Refactor discharge_reason data type to Integercare/1737
Enhanced Error Handling in AssetViewSetcare/1657
POC: AI discharge summarycare_fe/5147
[WIP] Integrate LiveKit for doctor connectcare/1227
[WIP] Integrate LiveKit for doctor connectcare/1221
feat(patient notes): add edit window validation and update endpointShared a comment on a pull request in coronasafe/ayushma_fe on December 14, 2023 at 4:11:34 PM
@rithviknishad LGTM but preview deploy failed ``` <html> <body> <!--StartFragment--> Failed to compile. -- 21:24:41.519 | 21:24:41.519 | ./chatbot/src/main.tsx:33:13 21:24:41.519 | Type error: Argument of type 'Element' is not assignable to parameter of type 'ReactNode'. 21:24:41.519 | 21:24:41.519 | 31 \| const root = createRoot(rootElement); 21:24:41.519 | 32 \| root.render( 21:24:41.519 | > 33 \| <React.StrictMode> 21:24:41.519 | \| ^ 21:24:41.519 | 34 \| <Chatbot 21:24:41.519 | 35 \| position={this.position} 21:24:41.519 | 36 \| projectID={this.projectID} 21:24:41.643 | error Command failed with exit code 1. <!--EndFragment--> </body> </html> ```
https://github.com/coronasafe/ayushma_fe/pull/153#issuecomment-1856133363
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2023 at 1:25:51 PM
> @Ashesh3 > > * [ ] when i submit the normal log update , i have been redirected to the critical care component Fixed now!
https://github.com/coronasafe/care_fe/pull/6831#issuecomment-1853915315
Shared a comment on an issue in coronasafe/care_fe on December 13, 2023 at 11:50:37 AM
Issue was an `_` in the middleware hostname. For more info refer: https://github.com/coronasafe/care/pull/1759#issuecomment-1848949837
https://github.com/coronasafe/care_fe/issues/6821#issuecomment-1853773897
Shared a comment on a pull request in coronasafe/care on December 11, 2023 at 3:34:24 PM
As per discussion, this change will be done in 3 steps: - Schema Changes - Migrating Data - Moving the temp field back to the original field and deprecate the temp field. I've converted this PR to just the schema change.
https://github.com/coronasafe/care/pull/1749#issuecomment-1850320430
Shared a comment on a pull request in coronasafe/care on December 10, 2023 at 12:22:33 PM
It appears that the root of our SSL verification issue is indeed related to the use of underscores in domain names. I conducted some tests and found the following: - `test_abc.domain.com` - fails SSL verification - `abc.domain.com` - passes SSL verification These tests were carried out on my Cloudflare domain around 5:45. Further, I referred to the DigiCert knowledge base, which confirms that underscores are not allowed in Fully Qualified Domain Names (FQDNs). Here's the link for reference: [DigiCert Knowledge Base](https://www.digicert.com/kb/ssl-support/underscores-not-allowed-in-fqdns.htm). Additionally, I checked the CA/Browser Forum's Ballot SC12 regarding the sunset of underscores in DNS names. The ballot has passed, clearly indicating a shift in standards concerning domain naming practices. You can find more details here: [CAB Forum - Ballot SC12](https://cabforum.org/2018/11/12/ballot-sc-12-sunset-of-underscores-in-dnsnames/). Based on these findings, it's evident that the issue lies in the use of underscores in the domain name, which is not compliant with SSL hostname matching standards. Therefore, this pull request will be closed as the problem does not stem from our code.
https://github.com/coronasafe/care/pull/1759#issuecomment-1848949837
Shared a comment on a pull request in coronasafe/care on December 9, 2023 at 12:36:18 PM
> Should we add validation to allow create of telemedicine rounds only if related consultation is DC? > > <img alt="image" width="847" src="https://private-user-images.githubusercontent.com/25143503/289269133-fe5f1da6-2ce6-4833-b58f-e87cd5092d9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDIxMjU2MzAsIm5iZiI6MTcwMjEyNTMzMCwicGF0aCI6Ii8yNTE0MzUwMy8yODkyNjkxMzMtZmU1ZjFkYTYtMmNlNi00ODMzLWI1OGYtZTg3Y2Q1MDkyZDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjA5VDEyMzUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxMmU0MmY3MzRkY2M2YzFkOWY3ZTcyMDVjZjcyODA4ZDQ3ZDVlOTRhMjkyNjllNjQwYmQ4Y2FlY2ViNzRmYmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.70NTdPYUEDJ2EWpyR9wXyNLrfxwoLBhLTqICQ3Zc264"> The option is already hidden in the frontend, but I do agree it's a best practice to add a validation here to ensure data consistency.
https://github.com/coronasafe/care/pull/1760#issuecomment-1848397981
Shared a comment on a pull request in coronasafe/care_fe on December 7, 2023 at 8:15:14 AM
> @Ashesh3 ![image](https://private-user-images.githubusercontent.com/57055998/286719778-5929f512-57c7-4be1-9686-bf3636d17879.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE5MzAyMzUsIm5iZiI6MTcwMTkyOTkzNSwicGF0aCI6Ii81NzA1NTk5OC8yODY3MTk3NzgtNTkyOWY1MTItNTdjNy00YmUxLTk2ODYtYmYzNjM2ZDE3ODc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjA3VDA2MTg1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmNjkxNzkyZTdiNjc5N2ZjN2IzNmJmNzVjYjEwM2I0YWJhZDU0YzcxZjYwZmE1ZDBlNjRmODVmMGE1YTI5MWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.G73DLWeGw0jIaqPSd5Y7xhYAZ0M2BfZY4TL5-kCYt90) > > [deploy-preview-6755--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/update](https://deploy-preview-6755--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/update) > > can you check this issue as well Resolved
https://github.com/coronasafe/care_fe/pull/6755#issuecomment-1844865479
Shared a comment on a pull request in coronasafe/care_fe on December 7, 2023 at 8:14:48 AM
> p/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/update Resolved
https://github.com/coronasafe/care_fe/pull/6755#issuecomment-1844864975
Shared a comment on a pull request in coronasafe/care on December 6, 2023 at 10:19:11 AM
Yep, done! > > Hey, I am not deleting any files 😅 Just added more facilities and patients to the existing dummy data. I think the change size `+1 −3,128` might have been confusing since the new data is all in a single line. This is to discourage someone manually working with the json file directly. > > Oh so that's why the title 😅, formatting the json gave more clarity, > > can you regenerate the fixtures by excluding, `facility.historicalpatientregistration` and `facility.historicalfacilitycapacity` they are not required and take half of the file size and the `facility_users.json` seems redundant, so both the command and file can be removed yep, done!
https://github.com/coronasafe/care/pull/1748#issuecomment-1842585809
Shared a comment on a pull request in coronasafe/care on December 6, 2023 at 9:30:29 AM
> Deleting this will throw an error in > > https://github.com/coronasafe/care/blob/033d0855cdb4a602327e1f4f19808a8d706db4ed/care/facility/management/commands/load_dummy_data.py#L29-L31 > > as the first file is missing, the other two will fail due to constraint error. > > These files are useful for setting up the backend for initial testing, so we should keep these instead and only run > > https://github.com/coronasafe/care/blob/033d0855cdb4a602327e1f4f19808a8d706db4ed/care/facility/management/commands/load_dummy_data.py#L25-L28 > > > for cypress Hey, I am not deleting any files 😅 Just added more facilities and patients to the existing dummy data. I think the change size `+1 −3,128` might have been confusing since the new data is all in a single line. ![image](https://github.com/coronasafe/care/assets/3626859/81bb0110-176e-4313-9a2e-c0a41b20195f)
https://github.com/coronasafe/care/pull/1748#issuecomment-1842507937
Shared a comment on a pull request in coronasafe/care_fe on December 5, 2023 at 5:48:21 PM
> @sainak any ETD for this PR status, as its been stale with no activity for 3 weeks ? ^ @sainak cc: @nihal467
https://github.com/coronasafe/care_fe/pull/6003#issuecomment-1841312774
Shared a comment on an issue in coronasafe/care_fe on December 5, 2023 at 5:47:47 PM
@sainak are you still working on this?
https://github.com/coronasafe/care_fe/issues/6006#issuecomment-1841311935
Shared a comment on a pull request in coronasafe/care on December 3, 2023 at 9:29:54 AM
@vigneshhari could you review this?
https://github.com/coronasafe/care/pull/1665#issuecomment-1837422842
Shared a comment on an issue in coronasafe/care_fe on November 30, 2023 at 2:07:37 PM
Unable to reproduce the issue. Need more details about the patient, specifically regarding any changes made in the last few days that could have led to this mismatch.
https://github.com/coronasafe/care_fe/issues/6747#issuecomment-1833849147
Shared a comment on an issue in coronasafe/care_fe on November 29, 2023 at 5:41:58 AM
We now have a cypress test for posting doctor notes
https://github.com/coronasafe/care_fe/issues/4235#issuecomment-1831256950
Shared a comment on an issue in coronasafe/care_fe on November 29, 2023 at 5:17:25 AM
@nihal467 We now have a cypress test for posting doctor notes. Can this issue be closed?
https://github.com/coronasafe/care_fe/issues/4235#issuecomment-1831237887
Shared a comment on an issue in coronasafe/care_fe on November 29, 2023 at 5:13:00 AM
@AshrafMd-1 What are the updates on this issue?
https://github.com/coronasafe/care_fe/issues/6665#issuecomment-1831234732
Shared a comment on an issue in coronasafe/care_fe on November 29, 2023 at 4:46:56 AM
@aparnacoronasafe Is this still relevant after the doctor notes was redesigned as a chat feature? cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4884#issuecomment-1831210622
Shared a comment on an issue in coronasafe/care_fe on November 29, 2023 at 4:25:43 AM
@sriharsh05 Any updates on this issue?
https://github.com/coronasafe/care_fe/issues/6615#issuecomment-1831196253
Shared a comment on an issue in coronasafe/care_fe on November 27, 2023 at 6:13:37 AM
Considerations while working on this issue: - Modify the login page to include a second step for 2FA. This could be a field for entering a verification code after successful verification of username and password combination. - 2FA method would be TOTP ( @bodhish can you confirm this? ) - Integrate 2FA Library: For TOTP, integrate a library that supports it, such as PyOTP in Python at the backend. - At the time of account creation or through account settings, allow users to enroll in 2FA. This will involve generating a secret key for the user, which they can add to their authentication app. They should be able to add/remove 2FA at any time through their profile settings. - Offer fallback options like backup codes in case the user loses access to their 2FA device. - Store the secret key for TOTP securely in the database. - Consider rate limiting 2FA attempts to prevent brute force attacks. - Provide clear instructions and support for users to understand how to set up and use 2FA.
https://github.com/coronasafe/care_fe/issues/6715#issuecomment-1827183063
Shared a comment on a pull request in coronasafe/care_fe on November 22, 2023 at 2:35:16 PM
For added context, When the sandbox attribute is present, it will: - treat the content as being from a unique origin - block form submission - block script execution - disable APIs - prevent links from targeting other browsing contexts - prevent content from using plugins (through `<embed>`, `<object>`, `<applet>`, or other) - prevent the content to navigate its top-level browsing context - block automatically triggered features (such as automatically playing a video or automatically focusing a form control)
https://github.com/coronasafe/care_fe/pull/6691#issuecomment-1822889733
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2023 at 12:12:30 PM
> @Ashesh3 the issue is not solved Should be fixed now. ![image](https://github.com/coronasafe/care_fe/assets/3626859/0e43aea2-51ea-474d-a55a-0ca3cee16aba)
https://github.com/coronasafe/care_fe/pull/6379#issuecomment-1803717020
Shared a comment on an issue in coronasafe/care_fe on November 2, 2023 at 6:57:13 AM
> Hi @aparnacoronasafe, I am new to this and would like to contribute, let me know if you can assign this to me. Cheers! Just a heads up, @sriharsh05 had already requested this issue first, so we're going to assign it to them. But there are plenty of other issues up for grabs. Thanks for understanding!
https://github.com/coronasafe/care_fe/issues/6518#issuecomment-1790173452
Shared a comment on an issue in coronasafe/care_fe on October 30, 2023 at 11:14:16 AM
> @Ashesh3, Is this issue solved? Because it is not showing the feed tab but it is showing the camera feed button in the header title buttons. Link : [care.coronasafe.in/facility/a3910fb7-db3d-4ddf-aa39-1f20e61d1453/patient/0e1a1fc1-148b-453d-9f86-04f9e56cf0ff/consultation/47d78e41-fe9f-4b3d-b0b7-9fc4117805b8](https://care.coronasafe.in/facility/a3910fb7-db3d-4ddf-aa39-1f20e61d1453/patient/0e1a1fc1-148b-453d-9f86-04f9e56cf0ff/consultation/47d78e41-fe9f-4b3d-b0b7-9fc4117805b8) > > User : devdistrictadmin There is no bed attached to this patient, hence the feed tab will not show. The issue is about hiding the feed tab for patients who have a linked bed to them but that linked bad has no camera asset attached to it. Example: https://care.coronasafe.in/facility/a3910fb7-db3d-4ddf-aa39-1f20e61d1453/patient/400cbedd-98d7-4f8f-b835-155ba71cc28d/consultation/6ae67a3d-305b-4404-bfd6-b21b0d0f8426 This patient has an attached bed without a camera, in this case the feed tab should be hidden: ![image](https://github.com/coronasafe/care_fe/assets/3626859/18248974-0ec7-44ac-819a-45245be372a9) The bed's location is `NICU` Here's the corresponding asset: (same location) https://care.coronasafe.in/facility/a3910fb7-db3d-4ddf-aa39-1f20e61d1453/assets/ed2edbd7-4581-434e-8c6a-4620b4d0a4a0 It's an HL7 monitor and not a camera, there are no cameras in the same location as that bed, so the feed tab should be hidden. @nihal467 can you double check this message for any corrections?
https://github.com/coronasafe/care_fe/issues/6475#issuecomment-1784970027
Shared a comment on an issue in coronasafe/care_fe on October 27, 2023 at 7:03:25 AM
The design of the doctor's notes has been updated to incorporate a chat feature. Could we re-evaluate the relevance of this feature in the context of the new design and conclude the assessment accordingly? cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4705#issuecomment-1782404110
Shared a comment on a pull request in coronasafe/care_fe on October 27, 2023 at 4:45:37 AM
> @Ashesh3 does this seem fine? Yep, seems fine.
https://github.com/coronasafe/care_fe/pull/6495#issuecomment-1782284991
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2023 at 10:16:25 AM
Try to think of a different way to pass the redirect url across pages/components 🤔 Something like the session expired page can silently pass the redirect url to the login component internally without exposing it through the URL. @rithviknishad any suggestions?
https://github.com/coronasafe/care_fe/pull/6495#issuecomment-1780825046
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2023 at 10:09:41 AM
> now it adds a / in between of the .my.subdomian do you want me to sanitise the redirect further like remove any . or other symbols in front of the redirect? @Ashesh3 @AshrafMd-1 The POC to redirect to a different domain still works 😅 , It can be exploited to redirect to a different website. POC: https://deploy-preview-6495--care-egov-staging.netlify.app/session-expired?redirect=https://google.com
https://github.com/coronasafe/care_fe/pull/6495#issuecomment-1780814949
Shared a comment on a pull request in coronasafe/ayushma_fe on October 26, 2023 at 9:35:42 AM
@skks1212 could you review this?
https://github.com/coronasafe/ayushma_fe/pull/143#issuecomment-1780759597
Shared a comment on an issue in coronasafe/care_fe on October 25, 2023 at 5:25:01 PM
> @Ashesh3 `setLocationsLoading` is removed and in place of that `loading` variable of `useQuery` is used to handle the loading state. If I'm wrong correct me. Can you provide a screenshot of the problem for a better understanding? I noticed that this issue was just fixed with rithviknishad in this PR: https://github.com/coronasafe/care_fe/pull/6494/ . Closing this issue as resolved.
https://github.com/coronasafe/care_fe/issues/6489#issuecomment-1779733327
Shared a comment on an issue in coronasafe/care_fe on October 25, 2023 at 7:44:17 AM
> I want to work on this, assign me You are assigned.
https://github.com/coronasafe/care_fe/issues/6489#issuecomment-1778697223
Shared a comment on a pull request in coronasafe/care_fe on October 25, 2023 at 7:24:38 AM
> @Ashesh3 <img alt="image" width="479" src="https://user-images.githubusercontent.com/57055998/277905918-2d944253-1d26-4b80-9343-18c025607012.png"> > > * [ ] link abha number UI is fully black, keep it consistent like other icons > * [ ] resolve the merge conflict > * [ ] get the UI opinion from @gigincg Resolved: ![image](https://github.com/coronasafe/care_fe/assets/3626859/aaa641c8-b00c-42d0-9e0c-0b41df2b5da3)
https://github.com/coronasafe/care_fe/pull/6440#issuecomment-1778668500
Shared a comment on a pull request in coronasafe/care_fe on October 25, 2023 at 6:16:11 AM
> @Ashesh3 are the UI changes implemented Yes, Implemented.
https://github.com/coronasafe/care_fe/pull/6440#issuecomment-1778584303
Shared a comment on an issue in coronasafe/care_fe on October 25, 2023 at 5:53:18 AM
@Omkar76 comment on this issue so that I can assign you.
https://github.com/coronasafe/care_fe/issues/6488#issuecomment-1778561046
Shared a comment on an issue in coronasafe/care_fe on October 24, 2023 at 2:00:11 PM
> I would like to take up this issue . Assigned it to you.
https://github.com/coronasafe/care_fe/issues/6486#issuecomment-1777273976
Shared a comment on a pull request in coronasafe/care on October 23, 2023 at 12:32:55 PM
> @Ashesh3 the filters are malfunctioning, check the linked front-end PR comment to see more details Issue fixed.
https://github.com/coronasafe/care/pull/1679#issuecomment-1775091812
Shared a comment on a pull request in coronasafe/care_fe on October 23, 2023 at 12:32:18 PM
> in new issue > Edit > Hide > Delete > [ Report content ](/contact/report-content?content_url=https%3A%2F%2Fgithub.com%2Fcoronasafe%2Fcare_fe%2Fissues%2F6456%23issuecomment-1768962019&report=nihal467+%28user%29) Issue fixed.
https://github.com/coronasafe/care_fe/pull/6456#issuecomment-1775090863
Shared a comment on a pull request in coronasafe/care_fe on October 20, 2023 at 7:46:08 AM
> @Ashesh3 <img alt="image" width="960" src="https://user-images.githubusercontent.com/57055998/275974014-78a68e62-7dab-4c6b-a335-8ec9a162ad1b.png"> > > * [ ] For non-asset class assets, this PR is showing the configuration button, which shouldn't be shown fixed now
https://github.com/coronasafe/care_fe/pull/6453#issuecomment-1772246900
Shared a comment on a pull request in coronasafe/care_fe on October 19, 2023 at 8:56:42 AM
> @Ashesh3 <img alt="image" width="960" src="https://user-images.githubusercontent.com/57055998/276545851-559d9b6a-4d7d-4da7-b3c8-3413512b4e17.png"> > > when i sign out, i have been redirected to session expired page Should be fixed now.
https://github.com/coronasafe/care_fe/pull/6472#issuecomment-1770364664
Shared a comment on a pull request in coronasafe/ayushma_fe on October 18, 2023 at 5:29:39 PM
> Member I tried that, but couldn't fit it in the design, for now you can click the file to preview it. If you can think of a good design for the previews, do let me know!
https://github.com/coronasafe/ayushma_fe/pull/142#issuecomment-1769014185
Shared a comment on a pull request in coronasafe/ayushma on October 18, 2023 at 5:28:18 PM
> @Ashesh3 > > files stored locally do not work (run without s3 creds) But we automatically store all files on s3 right?
https://github.com/coronasafe/ayushma/pull/372#issuecomment-1769012443
Shared a comment on a pull request in coronasafe/care_fe on October 17, 2023 at 10:22:22 AM
> @Ashesh3 <img alt="image" width="960" src="https://user-images.githubusercontent.com/57055998/275649122-d0dc996f-e2dd-48af-81ee-3933c6fba9b6.png"> > > the vital configure button is missing for district admin users Fixed. ### DistrictAdmin / Doctor ![image](https://github.com/coronasafe/care_fe/assets/3626859/64e3a7f0-8e65-4857-a4ff-c59f803e6118) ![image](https://github.com/coronasafe/care_fe/assets/3626859/a681e20b-6d0f-4a1b-801a-284a66aac647) ### Volunteer ![image](https://github.com/coronasafe/care_fe/assets/3626859/2049bded-5137-4635-b48b-9a049c840f2d) ![image](https://github.com/coronasafe/care_fe/assets/3626859/ec0758c7-e598-4784-95e6-20f04d8484d2)
https://github.com/coronasafe/care_fe/pull/6453#issuecomment-1766120832
Shared a comment on a pull request in coronasafe/care on October 16, 2023 at 8:59:23 AM
> LGTM, add tests Added!
https://github.com/coronasafe/care/pull/1669#issuecomment-1764031287
Shared a comment on an issue in coronasafe/care_fe on October 16, 2023 at 5:45:37 AM
Discussed on EOD call to mark this as wishlist as it's not an immediate requirement.
https://github.com/coronasafe/care_fe/issues/6439#issuecomment-1763769383
Shared a comment on an issue in coronasafe/care_fe on October 13, 2023 at 9:39:32 AM
> I would like to work on this issue, can you assign me to this? Sure, I've assigned you.
https://github.com/coronasafe/care_fe/issues/6438#issuecomment-1761221995
Shared a comment on a pull request in coronasafe/10bedicu on October 13, 2023 at 9:05:43 AM
This PR is ready to be tested and merged.
https://github.com/coronasafe/10bedicu/pull/73#issuecomment-1761174298
Shared a comment on a pull request in coronasafe/care on October 9, 2023 at 4:26:26 AM
> @Ashesh3 does the dummy data facility disappear after the middleware was fixed, which we discussed during the huddle Issue was with dummy data itself; PR is fine. Will make a new PR to fix the dummy data. No changes are needed on the PR.
https://github.com/coronasafe/care/pull/1642#issuecomment-1752329090
Shared a comment on a pull request in coronasafe/care_fe on October 6, 2023 at 5:37:30 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/273065042-c1778c05-31ac-4f2f-93b1-04cbdeeb44cb.png) > > the bug still persist Fixed!
https://github.com/coronasafe/care_fe/pull/6404#issuecomment-1750011580
Shared a comment on a pull request in coronasafe/care on October 3, 2023 at 8:09:00 AM
@sainak is this ready to review or still pending changes?
https://github.com/coronasafe/care/pull/1349#issuecomment-1744424961
Shared a comment on an issue in coronasafe/care_fe on September 29, 2023 at 7:05:11 AM
EDD: 9th October
https://github.com/coronasafe/care_fe/issues/6367#issuecomment-1740404761
Shared a comment on a pull request in coronasafe/care on September 28, 2023 at 8:52:38 AM
Waiting for: https://github.com/coronasafe/care_fe/pull/6224
https://github.com/coronasafe/care/pull/1221#issuecomment-1738738747
Shared a comment on an issue in coronasafe/care_fe on September 26, 2023 at 5:56:56 AM
EDD: 2nd October, 2023
https://github.com/coronasafe/care_fe/issues/6346#issuecomment-1734876399
Shared a comment on an issue in coronasafe/care_fe on September 25, 2023 at 11:11:56 AM
@rithviknishad I think we discussed this being the expected behavior, could you comment on it? cc: @gigincg
https://github.com/coronasafe/care_fe/issues/6340#issuecomment-1733454765
Shared a comment on an issue in coronasafe/care_fe on September 25, 2023 at 10:53:47 AM
@Deepjyoti14 EDD: 2nd October (next release)
https://github.com/coronasafe/care_fe/issues/6339#issuecomment-1733428862
Shared a comment on an issue in coronasafe/ayushma on September 20, 2023 at 12:34:03 PM
Can't be replicated. Reopen if applicable.
https://github.com/coronasafe/ayushma/issues/40#issuecomment-1727634258
Shared a comment on a pull request in coronasafe/care on September 19, 2023 at 5:49:52 PM
> You also need to create a signal to delete the cache when an asset updates, need tests for that edge as well. @vigneshhari added, could you review?
https://github.com/coronasafe/care/pull/1625#issuecomment-1726222564
Shared a comment on a pull request in coronasafe/care on September 19, 2023 at 4:25:22 PM
> needs test Added
https://github.com/coronasafe/care/pull/1625#issuecomment-1726034900
Shared a comment on a pull request in coronasafe/care on September 19, 2023 at 3:44:28 PM
@cp-Coder Can you resolve the merge conflicts?
https://github.com/coronasafe/care/pull/1260#issuecomment-1725921019
Shared a comment on a pull request in coronasafe/ayushma on September 17, 2023 at 5:30:10 PM
> > Is the endpoint supposed to be open? No authentication needed? > > for now, care-whisper endpoint is open we can deploy it in Private Network so that only care microservices can use it, or if required we can add auth. Currently its not for public usage so we don't necessary required auth we can just deploy it in a Private Network. The URL you added, `whisper.ohc.network` is not within a private network and is accessible and usable publicly. I am able to post URL of an audio and get it to transcribe. Just wanted to make sure if this was intentional and that by pushing that URL in this commit, the endpoint now being publicly known is okay.
https://github.com/coronasafe/ayushma/pull/327#issuecomment-1722525591
Shared a comment on a pull request in coronasafe/ayushma on September 17, 2023 at 2:51:03 PM
Is the endpoint supposed to be open? No authentication needed?
https://github.com/coronasafe/ayushma/pull/327#issuecomment-1722494184
Shared a comment on a pull request in coronasafe/care on September 15, 2023 at 11:17:22 AM
How about we also add celery monitoring? https://docs.sentry.io/platforms/python/guides/celery/crons/
https://github.com/coronasafe/care/pull/1611#issuecomment-1721104623
Shared a comment on a pull request in coronasafe/care_fe on September 11, 2023 at 11:32:34 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/266973050-24921106-8753-4453-ba31-791393a6474d.png) > > when we click on the set working hour button and the slide over comes in, the validation is throwing error without any user interaction. > > * It should run validation only when user click the update button > * increase the slide over length to show the error in single line Fixed
https://github.com/coronasafe/care_fe/pull/6243#issuecomment-1713697946
Shared a comment on a pull request in coronasafe/care on September 11, 2023 at 10:27:59 AM
Tests passing locally: ``` ---------------------------------------------------------------------- Ran 116 tests in 7.164s OK ```
https://github.com/coronasafe/care/pull/1592#issuecomment-1713607977
Shared a comment on a pull request in coronasafe/care on September 10, 2023 at 5:03:27 PM
@vigneshhari Got 2 approvals, could you review?
https://github.com/coronasafe/care/pull/1580#issuecomment-1712876307
Shared a comment on an issue in coronasafe/care_fe on September 6, 2023 at 3:00:38 PM
@gigincg What are the steps to proceed further on this?
https://github.com/coronasafe/care_fe/issues/3480#issuecomment-1708542026
Shared a comment on an issue in coronasafe/ayushma on September 5, 2023 at 1:09:12 PM
Fixed by https://github.com/coronasafe/ayushma/pull/289
https://github.com/coronasafe/ayushma/issues/264#issuecomment-1706590427
Shared a comment on an issue in coronasafe/care_fe on September 5, 2023 at 9:05:02 AM
> I don't have an iPhone :/ No worries, he was assigning it to me and selected your name by mistake 😅
https://github.com/coronasafe/care_fe/issues/6181#issuecomment-1706228618
Shared a comment on a pull request in coronasafe/ayushma on September 4, 2023 at 1:03:24 PM
> Hey @Ashesh3, did you make migrations after removing the size from the preset_questions field? Nope, made them now. Thanks for the heads up 😅
https://github.com/coronasafe/ayushma/pull/299#issuecomment-1705238692
Shared a comment on an issue in coronasafe/care_fe on August 30, 2023 at 3:46:52 PM
> Hi @rithviknishad , I solved this bug, will I make a PR? ![image](https://user-images.githubusercontent.com/97380192/264398920-dd610c0d-dece-402f-a971-2c310c590d4d.png) Yep, feel free to make a PR and link to this issue.
https://github.com/coronasafe/care_fe/issues/6101#issuecomment-1699428353
Shared a comment on a pull request in coronasafe/care_fe on August 29, 2023 at 8:41:20 AM
This should have been merged along with the backend change. @nihal467 could you test and get this merged?
https://github.com/coronasafe/care_fe/pull/6029#issuecomment-1697015933
Shared a comment on a pull request in coronasafe/care on August 29, 2023 at 8:30:43 AM
Sample Request: ``` GET http://127.0.0.1:8000/api/v1/patient/.../notes/ HTTP 200 { "count": 1, "next": null, "previous": null, "results": [ { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "note": "Hello World 1111", "facility": { ... }, "local_body_object": { ... }, "district_object": { ... }, "state_object": { ... }, "facility_type": { ... }, "read_cover_image_url": null, "features": [ ... ], "patient_count": 10, "bed_count": 10 }, "created_by_object": { ... }, "user_type": "DistrictAdmin", "created_date": "2023-08-28T19:56:35.529567+05:30", "modified_date": "2023-08-28T20:00:57.936003+05:30", "edits": [ { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T20:00:57.933797+05:30", "note": "Hello World 1111" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:58:06.112164+05:30", "note": "Hello World 5" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:57:17.134287+05:30", "note": "Hello World 4" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:56:35.532226+05:30", "note": "hey" } ] } ] } ``` ``` PUT http://localhost:4000/api/v1/patient/.../notes/848d9961-5c4b-450f-b4b6-e850e94ea393 {"note":"Hello World 123123123"} 200 OK { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "note": "Hello World 1111", "facility": { ... }, "local_body_object": { ... }, "district_object": { ... }, "state_object": { ... }, "facility_type": { ... }, "read_cover_image_url": null, "features": [ ... ], "patient_count": 10, "bed_count": 10 }, "created_by_object": { ... }, "user_type": "DistrictAdmin", "created_date": "2023-08-28T19:56:35.529567+05:30", "modified_date": "2023-08-28T20:00:57.936003+05:30", "edits": [ { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-29T14:00:09.195141+05:30", "note": "Hello World 123123123" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T20:00:57.933797+05:30", "note": "Hello World 1111" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:58:06.112164+05:30", "note": "Hello World 5" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:57:17.134287+05:30", "note": "Hello World 4" }, { "id": "848d9961-5c4b-450f-b4b6-e850e94ea393", "edited_by": { "id": 202, "first_name": "Bodhish", "username": "devdistrictadmin", "email": "", "last_name": "Thomas", "user_type": "DistrictAdmin", "last_login": "2023-08-29T13:56:07.336463+05:30" }, "edited_on": "2023-08-28T19:56:35.532226+05:30", "note": "hey" } ] } ```
https://github.com/coronasafe/care/pull/1221#issuecomment-1697000841
Shared a comment on a pull request in coronasafe/ayushma on August 23, 2023 at 6:16:38 PM
@khavinshankar merge conflicts, let's get this shipped soon :)
https://github.com/coronasafe/ayushma/pull/194#issuecomment-1690421649
Shared a comment on a pull request in coronasafe/ayushma_fe on August 23, 2023 at 6:15:50 PM
@khavinshankar could you resolve the minor merge conflicts, we'll test and get it merged as soon as they are cleared.
https://github.com/coronasafe/ayushma_fe/pull/54#issuecomment-1690420676
Shared a comment on a pull request in coronasafe/care_fe on August 23, 2023 at 8:28:33 AM
Added edit history as per discussion. Updated Screenshots in PR description.
https://github.com/coronasafe/care_fe/pull/5417#issuecomment-1689517424
Shared a comment on a pull request in coronasafe/care on August 23, 2023 at 8:27:31 AM
@vigneshhari @rithviknishad @sainak Could you guys review this?
https://github.com/coronasafe/care/pull/1522#issuecomment-1689516043
Shared a comment on a pull request in coronasafe/care on August 23, 2023 at 8:26:57 AM
@vigneshhari could you review this?
https://github.com/coronasafe/care/pull/1525#issuecomment-1689515216
Shared a comment on a pull request in coronasafe/care on August 23, 2023 at 8:26:43 AM
We have decided to merge this for now. An additional PR will be created later to move loading skills into the `load_data` management comment.
https://github.com/coronasafe/care/pull/1525#issuecomment-1689514863
Shared a comment on a pull request in coronasafe/ayushma_fe on August 23, 2023 at 8:25:25 AM
@skks1212 could you authorize the redeploy?
https://github.com/coronasafe/ayushma_fe/pull/88#issuecomment-1689512977
Shared a comment on an issue in coronasafe/care_fe on August 21, 2023 at 6:41:57 AM
@shrmp07 We plan to publish a documentation for setting up the notifications to work soon. Since this is a Priority 1 issue, I'll be taking care of it for now, feel free to work on other issues. Thank you :)
https://github.com/coronasafe/care_fe/issues/6061#issuecomment-1685741067
Shared a comment on a pull request in coronasafe/care on August 17, 2023 at 3:14:47 PM
> @Ashesh3 The migrations file that you've referred to seems to be part of old migrations and not present in the squashed/new migrations. > > 0 Skills present on a fresh instance :/ I am sure this isn't the expected behavior. We need the same set of skills on every instance. How about we ship this migration (since this is a P1 issue) to fix the typo in existing instances then integrate loading skills into the `load_data` management command?
https://github.com/coronasafe/care/pull/1525#issuecomment-1682464290
Shared a comment on a pull request in coronasafe/care on August 17, 2023 at 2:46:29 PM
> How did we populate skills in the first place? > > This could end up creating this skill on a fresh DB right during migrations right? > > And later when we populate all skills on a new instance we would end up having a duplicate right? (Since skill with the typo one is added during population after the corrected one was added during migration) The skills for existing deployments were loaded in a migration: https://github.com/coronasafe/care/pull/1176/files#diff-abf84bc2d0fa38116d391f2eb563939f4bb958dbc2c19d72d774e1bff6390070R58-R59 Maybe we should separately load the Skills to the database from a JSON files like we do for the states for new deployments. This PR will correct the typo in existing deployments.
https://github.com/coronasafe/care/pull/1525#issuecomment-1682417885
Shared a comment on an issue in coronasafe/care_fe on August 17, 2023 at 3:54:49 AM
> hi, is this open? if it is I'd like to contribute. thank you in advance. Yep, you can work on it.
https://github.com/coronasafe/care_fe/issues/6061#issuecomment-1681571962
Shared a comment on an issue in coronasafe/care_fe on August 8, 2023 at 2:50:02 PM
Closing after an internal discussion. Refer to the above comment for more details.
https://github.com/coronasafe/care_fe/issues/6009#issuecomment-1669771586
Shared a comment on an issue in coronasafe/care on August 8, 2023 at 6:15:53 AM
Fixed in https://github.com/coronasafe/care_fe/pull/4560
https://github.com/coronasafe/care/issues/1141#issuecomment-1668971674
Shared a comment on an issue in coronasafe/care_fe on August 7, 2023 at 2:48:31 PM
The decision to implement the SlideOver component was made in order to maintain consistency with the user interface of the other buttons on the User Info card. The Skills and Linked Facilities buttons both utilize the SlideOver component, and it was considered to provide a similar user experience for all buttons. While this may be a low priority issue, it is open for discussion!
https://github.com/coronasafe/care_fe/issues/6009#issuecomment-1668011972
Shared a comment on an issue in coronasafe/care_fe on August 7, 2023 at 4:54:05 AM
> Discussed with Gigin. Needed clarity on what are the requirements for the dashboard out of this. > > CARE must be able to send information on > > 1. How many individual doctors > 2. whats the actual resource available taking into account % availability? > > Eg: If a hospital has the following doctors: Doc 1: 100% Doc 2: 50% Doc 3: 50% > > Metabase must be able to gain data on > > 1. No. of individual doctors- 3 > 2. No. of resource (doctor) available: 2 (1+0.5+0.5) > > @Ashesh3 please deploy in a manner that allows metabase to get this info Requirements changed after discussion with Gigin, - We are adding a weekly working hours field for all the users on the platform. - This information is to be processed through Metabase to show the data in the format mentioned originally in the issue.
https://github.com/coronasafe/care_fe/issues/5956#issuecomment-1667184524
Shared a comment on a pull request in coronasafe/metabase_manager on August 5, 2023 at 10:40:32 AM
Manually upgraded
https://github.com/coronasafe/metabase_manager/pull/2#issuecomment-1666468032
Shared a comment on a pull request in coronasafe/care on August 3, 2023 at 1:40:19 PM
> @Ashesh3 a test is failing, also add a test for when `referred_to` is given and when both `referred_to` and `referred_to_external` are given Fixed and added more tests to cover `referred_to` specifically.
https://github.com/coronasafe/care/pull/1506#issuecomment-1664005037
Shared a comment on an issue in coronasafe/care on August 3, 2023 at 7:34:49 AM
@rithviknishad Expected error, the middleware was down, so when iterating through the status records, it was not an array of statuses, instead array of characters of the error page's html. We can ignore it for now. URL in above error: https://dev_middleware.coronasafe.live/devices/status Sample working hostname: https://dev-server-2.coronasafe.live/devices/status
https://github.com/coronasafe/care/issues/1496#issuecomment-1663443059
Shared a comment on a pull request in coronasafe/care_fe on August 3, 2023 at 7:02:02 AM
Waiting for backend PR: https://github.com/coronasafe/care/pull/1506
https://github.com/coronasafe/care_fe/pull/5730#issuecomment-1663402369
Shared a comment on an issue in coronasafe/care on August 3, 2023 at 5:47:14 AM
> @sainak I tried running a local pre-commit to run `./manage.py makemigrations --check --dry-run` > > This works fine when running via CLI (`git commit -m ...`), but fails to run when commiting from vscode git extension. Failed to import Django. Does the vscode git command run outside the context of the current virtual environment, hence the failing import?
https://github.com/coronasafe/care/issues/1499#issuecomment-1663327400
Shared a comment on an issue in coronasafe/care on August 3, 2023 at 5:33:35 AM
Taking a look
https://github.com/coronasafe/care/issues/1496#issuecomment-1663317346
Shared a comment on an issue in coronasafe/care on August 2, 2023 at 6:08:19 PM
> There is a precommit hook for it > We can add that as well Do we already have that? I already have precommit hooks installed and I don't remember seeing any such error which missing the migration..
https://github.com/coronasafe/care/issues/1499#issuecomment-1662713463
Shared a comment on a pull request in coronasafe/care_fe on August 2, 2023 at 6:27:00 AM
Will be fixed in a newer PR which aims at redesigning the doctor notes.
https://github.com/coronasafe/care_fe/pull/5126#issuecomment-1661574509
Shared a comment on an issue in coronasafe/care_fe on August 1, 2023 at 3:26:37 AM
@aparnacoronasafe the issue needs to be re approached to make it useful for the platform. A team discussion is required before proceeding to implement the feature.
https://github.com/coronasafe/care_fe/issues/5956#issuecomment-1659507650
Shared a comment on a pull request in coronasafe/care on July 28, 2023 at 6:46:37 AM
> Tests :) Tests added, thanks for the nudge. 😅
https://github.com/coronasafe/care/pull/1484#issuecomment-1655122157
Shared a comment on a pull request in coronasafe/care on July 27, 2023 at 8:02:26 AM
> See #1480 Fixed.
https://github.com/coronasafe/care/pull/1475#issuecomment-1653099699
Shared a comment on a pull request in coronasafe/care_fe on July 25, 2023 at 9:06:15 AM
> @Ashesh3 resolve the merge conflict Resolved.
https://github.com/coronasafe/care_fe/pull/5844#issuecomment-1649427249
Shared a comment on a pull request in coronasafe/care on July 24, 2023 at 5:16:32 AM
Lint won't run on the auto generated squashed migration file.
https://github.com/coronasafe/care/pull/1277#issuecomment-1647223489
Shared a comment on a pull request in coronasafe/care_fe on July 21, 2023 at 1:55:07 PM
Testing it once manually too with generated records.
https://github.com/coronasafe/care_fe/pull/5896#issuecomment-1645631098
Shared a comment on a pull request in coronasafe/care on July 19, 2023 at 11:30:58 AM
> @Ashesh3 resolve the conflicts Resolved.
https://github.com/coronasafe/care/pull/1221#issuecomment-1641914143
Shared a comment on a pull request in coronasafe/care_fe on July 18, 2023 at 5:22:58 PM
Note to tester: Please test the following pages for logo placement and sizes: - Login page - Patient/SamplePreview.tsx - Shifting/ShiftDetails.tsx - Sidebar collapsed
https://github.com/coronasafe/care_fe/pull/5886#issuecomment-1640652806
Shared a comment on a pull request in coronasafe/care on July 18, 2023 at 3:07:39 PM
> ## Suspect Issues > This pull request has been deployed and Sentry has observed the following issues: > > * ‼️ **APIException: ** `care.facility.tasks.asset_monitor.check_asset_s...` [View Issue](https://coronasafe-network.sentry.io/issues/4323661838/?referrer=github-pr-bot) > > Did you find this useful? React with a 👍 or 👎 This is expected. Some middleware endpoints are non functional.
https://github.com/coronasafe/care/pull/1454#issuecomment-1640408328
Shared a comment on a pull request in coronasafe/care on July 18, 2023 at 6:37:56 AM
> @Ashesh3 add tests for api endpoints Tests added.
https://github.com/coronasafe/care/pull/1454#issuecomment-1639591258
Shared a comment on a pull request in coronasafe/ayushma_fe on July 17, 2023 at 6:38:14 AM
> @Ashesh3 Deploy Preview is failing > > ``` > Type error: Could not find a declaration file for module 'json2csv'. '/vercel/path0/node_modules/json2csv/lib/json2csv.js' implicitly has an 'any' type. > ``` Should be fixed now.
https://github.com/coronasafe/ayushma_fe/pull/64#issuecomment-1637460867
Shared a comment on an issue in coronasafe/care_fe on July 14, 2023 at 8:33:40 AM
> @Ashesh3 where are we with this? any ETD @aparnacoronasafe The feature is built and ready but is just pending to be merged. We recently had a major change to the backend and had paused any merges for a week. It should be ready to review and merge now.. @vigneshhari could you take a look into the linked backend PR so we can get this merged? https://github.com/coronasafe/care/pull/1277
https://github.com/coronasafe/care_fe/issues/5363#issuecomment-1635503263
Shared a comment on a pull request in coronasafe/care_fe on July 13, 2023 at 8:48:54 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/252576643-399b4966-d570-464c-891d-a8ae48ce8659.png) > > * the font size and button colour is effected by this, currently, it is noticed in patient tab, have a deeper look and resolve it Fixed
https://github.com/coronasafe/care_fe/pull/5844#issuecomment-1633829117
Shared a comment on an issue in coronasafe/care_fe on July 12, 2023 at 2:13:21 PM
We are keeping the existing state and district list as the pin code api is not up to date with the latest state and district data.
https://github.com/coronasafe/care_fe/issues/5859#issuecomment-1632607934
Shared a comment on an issue in coronasafe/care on July 12, 2023 at 10:38:01 AM
We are keeping the existing state and district list as per an internal discussion with DevOps.
https://github.com/coronasafe/care/issues/1139#issuecomment-1632264532
Shared a comment on a pull request in coronasafe/care_fe on July 7, 2023 at 5:16:15 AM
@rithviknishad The page is crashing when opening advanced filters on User page.
https://github.com/coronasafe/care_fe/pull/5789#issuecomment-1624761288
Shared a comment on a pull request in coronasafe/care on July 6, 2023 at 2:02:04 PM
> This filter would work only when `is_active=False` right? Yep, active=False is being automatically applied on the frontend and sent along with this filter when this filter is selected.
https://github.com/coronasafe/care/pull/1440#issuecomment-1623736683
Shared a comment on a pull request in coronasafe/care_fe on July 1, 2023 at 3:13:54 PM
> ![image](https://user-images.githubusercontent.com/57055998/250281632-7195f9a9-03c9-4934-8f28-8c4af2c83d67.png) > > @Ashesh3 the bug exists, before removing the location badge, if you direct the facility badge first, the issue this there Fixed
https://github.com/coronasafe/care_fe/pull/5814#issuecomment-1615955212
Shared a comment on a pull request in coronasafe/care_fe on June 30, 2023 at 9:25:14 AM
- Error message for missing medical history field - COVID card height is overlapping medical history card - Make Insurance details header responsive
https://github.com/coronasafe/care_fe/pull/5793#issuecomment-1614386666
Shared a comment on a pull request in coronasafe/care_fe on June 21, 2023 at 1:19:53 PM
@nihal467 Made the fixes
https://github.com/coronasafe/care_fe/pull/5731#issuecomment-1600823741
Shared a comment on a pull request in coronasafe/care_fe on June 20, 2023 at 9:15:23 AM
@nihal467 Made the changes. ![image](https://github.com/coronasafe/care_fe/assets/3626859/432b187e-2b02-49f1-8604-1fb01e6787d0) ![image](https://github.com/coronasafe/care_fe/assets/3626859/8f76d6a5-6a5e-4ae3-afdf-e5f16bdd716a) ![image](https://github.com/coronasafe/care_fe/assets/3626859/a44f8f9c-b58e-4753-920d-e3589f1f9877) ![image](https://github.com/coronasafe/care_fe/assets/3626859/3cc39873-a19e-4c54-af71-b842e6acdecb) ![image](https://github.com/coronasafe/care_fe/assets/3626859/c30cf056-3f3b-4636-9df2-a793d558f519)
https://github.com/coronasafe/care_fe/pull/5641#issuecomment-1598413624
Shared a comment on an issue in coronasafe/ayushma_fe on June 19, 2023 at 1:02:55 PM
![image](https://github.com/coronasafe/ayushma_fe/assets/3626859/caa4bc63-ac37-4c9d-b763-349970d7718d) Issue is resolved already.
https://github.com/coronasafe/ayushma_fe/issues/20#issuecomment-1597153032
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 2:09:36 PM
Unassigning due to inactivity and taking it up with the form draft PR.
https://github.com/coronasafe/care_fe/issues/4980#issuecomment-1594744787
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2023 at 9:23:47 AM
Closed in favor of https://github.com/coronasafe/care_fe/pull/5671
https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590828550
Shared a comment on an issue in coronasafe/care on June 1, 2023 at 2:29:33 PM
@rithviknishad Regarding the relevancy of this issue, I noticed that we do have a pending TODO request about this behavior. https://github.com/coronasafe/care/blob/ed9361b61c8a676aa343d36fb8fee71f5d204379/care/facility/models/file_upload.py#L23 So, maybe we can have a periodic task to check `upload_completed` and delete incomplete FileUpload objects with a 1 day grace period. Let's still get a second opinion.
https://github.com/coronasafe/care/issues/1326#issuecomment-1572165672
Shared a comment on a pull request in coronasafe/ayushma on May 26, 2023 at 9:24:46 PM
No longer required, resolved by https://github.com/coronasafe/ayushma/pull/131
https://github.com/coronasafe/ayushma/pull/145#issuecomment-1564973057
Shared a comment on a pull request in coronasafe/care on May 19, 2023 at 8:53:54 PM
@vigneshhari any updates on this?
https://github.com/coronasafe/care/pull/1221#issuecomment-1555237214
Shared a comment on an issue in coronasafe/ayushma_fe on May 16, 2023 at 12:33:13 PM
Unblocking as https://github.com/coronasafe/ayushma/issues/59 is merged.
https://github.com/coronasafe/ayushma_fe/issues/3#issuecomment-1549576267
Shared a comment on a pull request in coronasafe/care_fe on May 15, 2023 at 12:54:44 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/238301366-61b822bf-3e74-4116-959d-b11124cc3fa4.png) > > when you click the "Save Doctor Capacity" button, the user is staying on the page, but it should redirect the person to the facility detail page. Fixed
https://github.com/coronasafe/care_fe/pull/5461#issuecomment-1547807329
Shared a comment on a pull request in coronasafe/ayushma_fe on May 14, 2023 at 3:19:14 PM
cc @ishanExtreme
https://github.com/coronasafe/ayushma_fe/pull/8#issuecomment-1546923289
Shared a comment on an issue in coronasafe/care_fe on May 8, 2023 at 10:12:15 AM
> @nihal467 @Ashesh3 Where are we with this Issue? Why dont I see a PR linked? @aparnacoronasafe I am not longer assigned to this issue. @sainak is taking care of this. cc'ing him here.
https://github.com/coronasafe/care_fe/issues/5237#issuecomment-1538120010
Shared a comment on a pull request in coronasafe/care_fe on May 3, 2023 at 9:24:46 AM
Updated Design: ![image](https://user-images.githubusercontent.com/3626859/235878928-996da05c-bd62-4d4a-9b52-ef45fa868352.png) ![image](https://user-images.githubusercontent.com/3626859/235879182-5f14bb40-eb09-42fa-a3d4-e0af05de0fd0.png) ![image](https://user-images.githubusercontent.com/3626859/235879055-bf3b400f-8709-4b1e-859d-8b034df0a922.png)
https://github.com/coronasafe/care_fe/pull/5131#issuecomment-1532708999
Shared a comment on an issue in coronasafe/care_fe on April 27, 2023 at 8:56:41 PM
- [x] Origin Facility staff is unable to update the following status in the shifting form: Destination Approved, Cancelled - Should be fixed by https://github.com/coronasafe/care/pull/1276 - [x] Destination Facility staff is unable to update the following status in the shifting form: Destination Approved, Complete - Should be fixed by https://github.com/coronasafe/care/pull/1276
https://github.com/coronasafe/care_fe/issues/5416#issuecomment-1526445701
Shared a comment on an issue in coronasafe/care_fe on April 24, 2023 at 10:53:00 AM
> @Ashesh3 @nihal467 Please expedite it @sainak Are the required changes done on the backend? Is this issue ready to be worked on at the front end?
https://github.com/coronasafe/care_fe/issues/5237#issuecomment-1519899521
Shared a comment on a pull request in coronasafe/care_fe on April 22, 2023 at 4:40:32 PM
Waiting on https://github.com/coronasafe/care/pull/1265
https://github.com/coronasafe/care_fe/pull/5323#issuecomment-1518700487
Shared a comment on a pull request in coronasafe/care_fe on April 21, 2023 at 3:25:20 PM
> @Ashesh3 why are the lines commented out, assuming that they can be uncommented at wartime, if that is the case can you use `wartime_shifting` env from useConfig Hey, those features were to be removed from shifting, hence i commented them once to test the UI. I will remove the comments and make a push. There's no mention of those commented features to be needed at warmode so they can be removed.
https://github.com/coronasafe/care_fe/pull/5323#issuecomment-1517997703
Shared a comment on a pull request in coronasafe/care on April 18, 2023 at 2:46:08 PM
The commits were not reflected on this PR, most likely a temporary issue with Github. I made a sample dummy commit to force the update here. The dummy commit can be ignored.
https://github.com/coronasafe/care/pull/1221#issuecomment-1513285872
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 5:56:59 PM
> This might add a bit more stress on the database, create a ticket to summarise both counts at the facility level with signals. I will merge this in to keep you folks unblocked. Made an issue for that here: https://github.com/coronasafe/care/issues/1259
https://github.com/coronasafe/care/pull/1223#issuecomment-1511834758
Shared a comment on a pull request in coronasafe/care on April 15, 2023 at 12:21:50 PM
Requested changes are made. Only validation is done to check for duplicate locations within the same facility. No constraints.
https://github.com/coronasafe/care/pull/1231#issuecomment-1509759892
Shared a comment on a pull request in coronasafe/care on April 14, 2023 at 6:55:59 AM
@vigneshhari any updates on this?
https://github.com/coronasafe/care/pull/1223#issuecomment-1508016629
Shared a comment on a pull request in coronasafe/care on April 14, 2023 at 6:55:39 AM
@vigneshhari any updates on this?
https://github.com/coronasafe/care/pull/1221#issuecomment-1508016310
Shared a comment on an issue in coronasafe/care_fe on April 12, 2023 at 2:31:05 PM
> @Ashesh3 Todo No. 2. Todo 1-5 are completed in the linked PR.
https://github.com/coronasafe/care_fe/issues/5300#issuecomment-1505383171
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 1:00:30 PM
> @Ashesh3 maybe we should have separate input fields for it so that user is clear about this feature. (Although we could make use of the same backend field) That would be more intuitive correct. Though I remember discussing both options (with and without the addition input) with Gigin and deciding on the current implementation. Let's take it up for discussion again.
https://github.com/coronasafe/care_fe/issues/5295#issuecomment-1501786096
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 12:53:54 PM
Possible duplicate of #4876 , that was resolved by allowing free flow text in the input itself if no hospitals matched the query. @aparnacoronasafe can you confirm?
https://github.com/coronasafe/care_fe/issues/5295#issuecomment-1501780120
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 11:53:05 AM
> @Ashesh3 what is the Expected date of completion for this? We had some issues last week regarding patient discharge. All those are resolved now. I'll get this feature done by tonight.
https://github.com/coronasafe/care_fe/issues/5237#issuecomment-1501730534
Shared a comment on a pull request in coronasafe/care_fe on April 6, 2023 at 10:55:44 AM
@nihal467 fixed the issues. ![image](https://user-images.githubusercontent.com/3626859/230355796-dd2eeb7f-03ff-4611-b6c9-5cd35f63ecb2.png) ![image](https://user-images.githubusercontent.com/3626859/230356465-3fff6018-ea36-41d4-98a3-1644a8d40d22.png)
https://github.com/coronasafe/care_fe/pull/5157#issuecomment-1498878620
Shared a comment on a pull request in coronasafe/care_fe on April 6, 2023 at 6:08:44 AM
@rithviknishad Side note, any clue on cypress timing out waiting for care_fe to start? https://github.com/coronasafe/care_fe/actions/runs/4625566014/jobs/8181444664#step:10:31
https://github.com/coronasafe/care_fe/pull/5249#issuecomment-1498541253
Shared a comment on a pull request in coronasafe/care_fe on April 6, 2023 at 6:06:39 AM
> @Ashesh3 possible duplicate of #5204. Does your pr solve anything additionally? Nothing additionally!
https://github.com/coronasafe/care_fe/pull/5249#issuecomment-1498539739
Shared a comment on a pull request in coronasafe/care on April 6, 2023 at 5:38:54 AM
> If this is a requirement then i would recommend creating a migration and moving the values into something that is queryable. Do create an issue for that and track separately. For the separate issue, you mean a migration to move the values to numeric? So that we can return the category sorted in any order without needing a custom `filter_backend`? In that case I'd imagine the numeric value to be lowest [0] (Comfort) to highest [n] (Critical).
https://github.com/coronasafe/care/pull/1235#issuecomment-1498518850
Shared a comment on a pull request in coronasafe/care_fe on April 5, 2023 at 2:36:50 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/230102593-9f7e95c3-6ada-4e72-a163-40f2708f424b.png) > > in the responsive view ,the UI is breaking Should be fixed now! ![image](https://user-images.githubusercontent.com/3626859/230114557-44673a72-65dc-49c6-9fb9-cb37a8fd5242.png) ![image](https://user-images.githubusercontent.com/3626859/230114341-5f906295-e8ca-457c-97bb-24c2a533ea61.png) ![image](https://user-images.githubusercontent.com/3626859/230114425-c9694674-26ba-4042-a152-c5d6380b75c1.png)
https://github.com/coronasafe/care_fe/pull/5247#issuecomment-1497601538
Shared a comment on an issue in coronasafe/ayushma on April 4, 2023 at 8:58:01 AM
> There is one already. I added it earlier, it's in `ayushma/utils/openaiapi.py` Looks good, I will refactor the `upsert` to use the method in utils.
https://github.com/coronasafe/ayushma/issues/17#issuecomment-1495600788
Shared a comment on a pull request in coronasafe/care_fe on April 3, 2023 at 4:34:18 PM
> @Ashesh3 could you also change the field to numeric input in the profile update page? > > (reported by @nihal467) Done! ![image](https://user-images.githubusercontent.com/3626859/229572092-f26f930c-7588-44cb-9395-41d95ac8ef7f.png)
https://github.com/coronasafe/care_fe/pull/5207#issuecomment-1494638199
Shared a comment on a pull request in coronasafe/care_fe on March 30, 2023 at 7:56:55 PM
> @Ashesh3 @rithviknishad we need to convert the field, which will be a simple input field just to input the number of experience in years Done! ![image](https://user-images.githubusercontent.com/3626859/228949911-6b611017-d2a9-409f-83be-d110f625ff33.png) ![image](https://user-images.githubusercontent.com/3626859/228949928-19d277e6-4d22-4b92-8dbe-ae02f3f4b450.png)
https://github.com/coronasafe/care_fe/pull/5207#issuecomment-1490862550
Shared a comment on a pull request in coronasafe/care_fe on March 30, 2023 at 4:39:49 PM
> I thought since the label has changed to `Years of Exp.` we had to change the field also to a number input and calculate experience_commenced_on based on input before firing the request I thought the same, @nihal467 could you take a look if we need to convert the field to a number input?
https://github.com/coronasafe/care_fe/pull/5207#issuecomment-1490606167
Shared a comment on an issue in coronasafe/care_fe on March 29, 2023 at 2:35:02 PM
@aparnacoronasafe Can you shed some light on "SOS prescription input format"? Is it one of the below? ![image](https://user-images.githubusercontent.com/3626859/228573066-621d2cc5-a8d6-4375-8a97-811ffa669a04.png) ![image](https://user-images.githubusercontent.com/3626859/228573110-903f5cf3-8d4b-4f77-b316-9be037516b0b.png)
https://github.com/coronasafe/care_fe/issues/5196#issuecomment-1488745766
Shared a comment on a pull request in coronasafe/care_fe on March 27, 2023 at 1:58:02 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/227960389-d62fe33d-a12e-4f1c-a2fd-78c61e2855fd.png) > > rename it to booster dose , dont make it in full length Done
https://github.com/coronasafe/care_fe/pull/5162#issuecomment-1485152066
Shared a comment on a pull request in coronasafe/care_fe on March 25, 2023 at 6:53:14 AM
With this my build time goes down from `210s` to `57s` and hot reload time goes down to `6s` from `28s`. This is really helpful. Great work! Tested on 3.0 GHz Ampere® Altra™ x4 core CPU with 32GB memory.
https://github.com/coronasafe/care_fe/pull/5140#issuecomment-1483744761
Shared a comment on a pull request in coronasafe/care_fe on March 23, 2023 at 10:51:03 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/227165940-8431cdf5-763f-429f-b994-925fb1167a93.png) > > * [ ] unable to create a new asset > * [ ] the location heading is missing Should be fixed now.
https://github.com/coronasafe/care_fe/pull/5155#issuecomment-1480972801
Shared a comment on an issue in coronasafe/care_fe on March 7, 2023 at 3:21:37 PM
The UUID QR code that is generated automatically has been removed. The issue can be closed.
https://github.com/coronasafe/care_fe/issues/2241#issuecomment-1458357713
Shared a comment on a pull request in coronasafe/care_fe on March 6, 2023 at 10:34:16 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/223034494-7571600c-9ad2-4f25-9948-c51fd656a342.png) > > it is functioning good, but it is not responsive in mobile view Fixed. ![image](https://user-images.githubusercontent.com/3626859/223085822-1ea933a6-63ec-4864-a3e4-97841ff5e83c.png)
https://github.com/coronasafe/care_fe/pull/5039#issuecomment-1455881363
Shared a comment on an issue in coronasafe/care_fe on March 1, 2023 at 9:07:49 AM
Unable to replicate. ![msedge_dhMV8vIC2z](https://user-images.githubusercontent.com/3626859/222090699-814fb9b2-4e9a-477d-a92d-25f1f4a6866e.gif) Tested on: - Iphone 14 - iOS: v16.2 - Safari: 16.3
https://github.com/coronasafe/care_fe/issues/5015#issuecomment-1449636809
Shared a comment on a pull request in coronasafe/care on February 21, 2023 at 5:07:24 AM
> @Ashesh3 But a District Admin should not be able to clear access for a State Admin. Is that edge handled here? Should be fixed. I didn't infer the edge case from the linked issue which stated that *any user* >= District admin should be able to clear home facility of *any* other user.
https://github.com/coronasafe/care/pull/1198#issuecomment-1437866379
Shared a comment on a pull request in coronasafe/care on February 20, 2023 at 4:32:29 AM
> if requesting user has permission to the selected user, do we need to check anything else? Correct, we do not need to check for facility access with the user again because the facility to be removed is not specified by the user, but rather it is the facility already associated with the user. I've made the appropriate changes regarding this.
https://github.com/coronasafe/care/pull/1194#issuecomment-1436317365
Shared a comment on an issue in coronasafe/care_fe on February 13, 2023 at 7:27:58 AM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4809#issuecomment-1427470901
Shared a comment on an issue in coronasafe/care_fe on February 13, 2023 at 7:27:58 AM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4809#issuecomment-1427470901
Shared a comment on a pull request in coronasafe/care_fe on February 9, 2023 at 8:32:15 AM
> Preserve white bg for default variant Done! ![GenerousFantail](https://user-images.githubusercontent.com/3626859/217758533-87aca033-a925-4ac1-a8b5-d24bcf89a542.gif)
https://github.com/coronasafe/care_fe/pull/4782#issuecomment-1423814224
Shared a comment on a pull request in coronasafe/care_fe on February 9, 2023 at 7:59:24 AM
> @Ashesh3 initially we were using string and later we changed it to an array, so is that factored in? Yes, that is factored in at both backend and frontend. It's strictly to array only now. (Backend PR merged already)
https://github.com/coronasafe/care_fe/pull/2536#issuecomment-1423778319
Shared a comment on an issue in coronasafe/care_fe on February 8, 2023 at 3:08:35 PM
> This needs to be done. @Ashesh3 why did you unassign yourself.? Can somebody else take it up? @vigneshhari Hey, I unassigned myself as I was occupied for the next 2 weeks (from Jan 3) so I wasn't able to work on this, anyone else feel free to take it up!
https://github.com/coronasafe/care_fe/issues/3479#issuecomment-1422744959
Shared a comment on a pull request in coronasafe/care on February 7, 2023 at 4:27:04 PM
> @Ashesh3 if we already have a page then lets not work on this now; I think I missed that part during the call. > > I was thinking you where creating a new page just to get around this filter issue. Yep, we already have a separate page just to show Facility users. The issue was to remove that separate page and move it into the Users page.
https://github.com/coronasafe/care/pull/1160#issuecomment-1421057899
Shared a comment on a pull request in coronasafe/care on February 7, 2023 at 4:17:49 PM
@vigneshhari We already have a separate component for showing facility users. An issue was made to move it within the Users page. I discussed this with @gigincg and @bodhish and they are willing to go ahead with adding facility filter support to the Users page so we can shift our Facility Users page to Users page. Can we reevaluate this PR?
https://github.com/coronasafe/care/pull/1160#issuecomment-1421042839
Shared a comment on a pull request in coronasafe/care_fe on February 7, 2023 at 2:14:02 PM
> @Ashesh3 could you try setting `accent-[color]` class? Didn't have any effect here, but `text-[color]` worked.
https://github.com/coronasafe/care_fe/pull/4741#issuecomment-1420843885
Shared a comment on a pull request in coronasafe/care_fe on February 7, 2023 at 2:12:35 PM
Fixed: ![SecondhandAmbushbug](https://user-images.githubusercontent.com/3626859/217268224-a37ea224-4fb7-4a90-86c7-3e72d9a01186.gif)
https://github.com/coronasafe/care_fe/pull/4741#issuecomment-1420841484
Shared a comment on a pull request in coronasafe/care_fe on February 7, 2023 at 1:54:41 PM
Waiting for https://github.com/coronasafe/care/pull/1181
https://github.com/coronasafe/care_fe/pull/4784#issuecomment-1420813507
Shared a comment on a pull request in coronasafe/care_fe on February 5, 2023 at 4:36:34 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/216831675-32345583-b298-4679-8cb0-36995271a0e3.png) > > state-admin are not able to add skill, as per issue, district admin and above should be able to add skills Fixed
https://github.com/coronasafe/care_fe/pull/4767#issuecomment-1418127904
Shared a comment on a pull request in coronasafe/care_fe on February 3, 2023 at 9:26:39 AM
Waiting for: https://github.com/coronasafe/care/pull/1175
https://github.com/coronasafe/care_fe/pull/2536#issuecomment-1415459290
Shared a comment on a pull request in coronasafe/care on January 21, 2023 at 1:38:58 PM
> I would make this a separate api view, maybe under the facilities detailed view Hi, I'm trying to understand your comment about making this a separate API view under the facilities detailed view. Are you suggesting that I create a new endpoint specifically for filtering users by facility and that this endpoint should be located under the detailed view of facilities? For example, `/facilities/<facility_id>/users`? Don't we already have a dedicated endpoint for this at: https://github.com/coronasafe/care/blob/master/care/users/api/viewsets/users.py#L218 Just want to make sure I understand your suggestion correctly before implementing it.
https://github.com/coronasafe/care/pull/1160#issuecomment-1399253544
Shared a comment on an issue in coronasafe/care_fe on January 13, 2023 at 2:22:41 PM
Additional Context: The validation for the middleware host was added yesterday on the backend. https://github.com/coronasafe/care/blame/master/care/facility/api/serializers/facility.py#L122 ``` def validate_middleware_address(self, value): value = value.strip() if not value or not value.startswith("http"): raise serializers.ValidationError("Invalid URL") if value.endswith("/"): raise serializers.ValidationError("URL should not end with /") return value ```
https://github.com/coronasafe/care_fe/issues/4578#issuecomment-1381927594
Shared a comment on an issue in coronasafe/care_fe on January 13, 2023 at 1:43:29 PM
> @Ashesh3 dev_middleware.coronasafe.live, this is the middleware I am able to enter `https://dev_middleware.coronasafe.live` for the middleware URL. It's not a valid URL without the protocol at the beginning. (http/https)
https://github.com/coronasafe/care_fe/issues/4578#issuecomment-1381867944
Shared a comment on an issue in coronasafe/care_fe on January 13, 2023 at 1:38:29 PM
@nihal467 are you sure you are using a valid URL for the configuration? `http://example.com` works fine `invalid_input` fails, as expected
https://github.com/coronasafe/care_fe/issues/4578#issuecomment-1381861598
Shared a comment on a pull request in coronasafe/care on January 13, 2023 at 5:32:45 AM
@vigneshhari Any updates on this?
https://github.com/coronasafe/care/pull/789#issuecomment-1381335299
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2023 at 6:14:24 AM
> @Ashesh3 is the PR ready for testing and check the merge conflict It's ready now, changes are made. ![image](https://user-images.githubusercontent.com/3626859/211731241-eed4af15-1959-46ce-9b3c-1c3f4d39f5bc.png)
https://github.com/coronasafe/care_fe/pull/4462#issuecomment-1378286706
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 2:04:52 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/210793792-0cc48f98-0c85-4419-ac3c-02a0ae17d851.png) > > can you get the alignment to the left for both pop-up Fixed.
https://github.com/coronasafe/care_fe/pull/4462#issuecomment-1372255239
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 8:38:16 AM
> @Ashesh3 as per our slack communication, you have mentioned about minor changes, so changing this to work in progress Changes are done. ![image](https://user-images.githubusercontent.com/3626859/210737013-8054bc90-fbbc-41e6-897e-b53bb0f87808.png) ![image](https://user-images.githubusercontent.com/3626859/210736996-6f25301b-82f9-40b7-9019-168e7f0d0f04.png)
https://github.com/coronasafe/care_fe/pull/4462#issuecomment-1371925073
Shared a comment on a pull request in coronasafe/care_fe on January 2, 2023 at 4:34:30 PM
@nihal467 Changes are done. - Made it more gray - Reduced the icon size in collapsed menu ![image](https://user-images.githubusercontent.com/3626859/210257871-e8684f65-a0df-48cb-b608-cb312849ea49.png) ![image](https://user-images.githubusercontent.com/3626859/210257874-80eb4deb-96aa-4dcb-99ea-b57bd6aa6eac.png)
https://github.com/coronasafe/care_fe/pull/4444#issuecomment-1369079876
Shared a comment on a pull request in coronasafe/care_fe on December 30, 2022 at 2:44:01 PM
@aparnacoronasafe Can you check this and offer your thoughts on the changed design.
https://github.com/coronasafe/care_fe/pull/4444#issuecomment-1367953602
Shared a comment on an issue in coronasafe/care on December 28, 2022 at 2:47:33 PM
cc: @gigincg @vigneshhari
https://github.com/coronasafe/care/issues/1139#issuecomment-1366704999
Shared a comment on a pull request in coronasafe/care_fe on December 28, 2022 at 12:28:18 PM
@nihal467 the autofill only happens when a valid state/district match is found. Your Pincode (`671310`) is for: State: `Kerla` District: `Kasaragod` But we do not have that district in our list, hence autofill does not do anything in that case and lets the user select the fields manually. It seems we do have a similar district, `Kasargode`. Maybe it's misspelt or something. But the autofill works correctly as it's supposed to, i.e, not autofill the state and district if no match is found.
https://github.com/coronasafe/care_fe/pull/4429#issuecomment-1366615892
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 11:43:01 AM
> I thought there was something like (HTML way) since it's pretty common behaviour in other websites to not validate until focus. > > Additional JS, I also wouldn't proceed 😅 I am personally not aware of any such method, tried asking OpenAI too 😬 . ![image](https://user-images.githubusercontent.com/3626859/209434380-ae4bcbe8-79bf-484f-a91e-50dbc9dca885.png) So, I guess we'll have to keep the existing behavior in this case.
https://github.com/coronasafe/care_fe/issues/4394#issuecomment-1364515854
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 11:25:48 AM
> or is there a way to not validate the input until the element got focus or something? @rithviknishad I am afraid that'd require additional JS to keep a watch for the initial focus, how about we keep the existing behavior where the fields will only be validated after a form submission? cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4394#issuecomment-1364513362
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 10:57:24 AM
Unable to replicate the issue. Tested on Chrome v108 running on Windows 10/11. I always get the dark blue variant. `Win 11 / Chrome 108` ![image](https://user-images.githubusercontent.com/3626859/209432667-4c838def-bb07-4c56-9492-b0f7a2813852.png) `Win 10 / Chrome 108` ![image](https://user-images.githubusercontent.com/3626859/209432670-a1d23947-48f1-4325-b9bd-e2ed5a21d85b.png) `Win 11 / Opera 94` ![image](https://user-images.githubusercontent.com/3626859/209432761-f0fce5d3-d1c1-4d23-8b7e-7ae9b7ba8152.png)
https://github.com/coronasafe/care_fe/issues/4393#issuecomment-1364509501
Shared a comment on a pull request in coronasafe/care_fe on December 23, 2022 at 9:31:23 AM
Any update on this being merged @khavinshankar @nihal467 ?
https://github.com/coronasafe/care_fe/pull/4251#issuecomment-1363783280
Shared a comment on a pull request in coronasafe/care_fe on December 23, 2022 at 5:48:43 AM
> @khavinshankar check out this PR and @Ashesh3 check the cypress failed tag Fixed now!
https://github.com/coronasafe/care_fe/pull/4307#issuecomment-1363640014
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 3:25:57 PM
@nihal467 should be fixed now.
https://github.com/coronasafe/care_fe/pull/4351#issuecomment-1357840797
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 9:03:21 AM
@rithviknishad The Cypress tests might need to be updated too. ![image](https://user-images.githubusercontent.com/3626859/208387934-9ff0a1db-58bd-4d45-b2e8-e07d49035436.png)
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1357313909
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:33:48 PM
> along with `gap-2` also maybe? it's still overridable since the `classNames` passed as a prop is appended to the end Yep, a default template for a button would make it much easier to use by default, while also allowing it to be overridden by `classNames`. So yea i think we can add those properties by default.
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356822887
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:31:14 PM
> @Ashesh3 what do you think about updating the `ButtonV2` component to have `inline-flex items-center` already present in it's classNames? That'd be super clean and helpful!
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356822539
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:28:01 PM
@rithviknishad `justify-flex` along with `items-center` seem to help remedy the alignment problem. ![image](https://user-images.githubusercontent.com/3626859/208306517-94d2a71c-6822-46bb-9ed2-473f5314f72c.png) Before: ![image](https://user-images.githubusercontent.com/3626859/208306549-8d2ecb20-1097-4968-8ca9-20d4669e1ca8.png) After: ![image](https://user-images.githubusercontent.com/3626859/208306553-1a6f2708-9950-45ff-9d88-6356445088ba.png)
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356822085
Shared a comment on a pull request in coronasafe/care_fe on December 18, 2022 at 1:26:19 PM
@nihal467 @khavinshankar Thoughts on the new design? - Replaced the page with a modal ![TomatoIndianskimmer](https://user-images.githubusercontent.com/3626859/208300848-df1c1f8b-305b-4284-9e74-3a3662603353.gif)
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1356798226
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 4:16:56 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/208058967-9dd825cb-6a48-4ea3-bf1f-27c4699daee6.png) > > make the three button in three rows when it is in responsive view Done! ![image](https://user-images.githubusercontent.com/3626859/208141983-63bb30d6-ffb5-46ac-bbe2-9fe70387ff55.png)
https://github.com/coronasafe/care_fe/pull/4314#issuecomment-1355160726
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2022 at 12:44:19 PM
> @Ashesh3 @khavinshankar so what are we doing now of this PR Tried a few different designs, will showcase the modal design tomorrow.
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1348479514
Shared a comment on an issue in coronasafe/care_fe on December 13, 2022 at 8:34:35 AM
@nihal467 Currently asset creation is specific to a particular facility, when you click the create asset button on a facility page, you see a list of locations within the facility itself where you can create assets. We can add a create asset button here on the asset page and show facility selection menu in the creation form itself so that the user can select the facility + location, is that what you are looking for?
https://github.com/coronasafe/care_fe/issues/4290#issuecomment-1347928287
Shared a comment on an issue in coronasafe/care on December 7, 2022 at 10:59:03 AM
> Why is this required? We wont proxy any requests in the backend, we will have to populate the values in the tables we have to store geo structures. This is required to autofill the district and state when the user enters a pin code (See https://github.com/coronasafe/care_fe/issues/3940). As per your response, I assume we are not going to proxy the discussed api endpoint. Are you suggesting populating the pin code details into the database as a separate table and make an endpoint out of it?
https://github.com/coronasafe/care/issues/1107#issuecomment-1340790576
Shared a comment on a pull request in coronasafe/care_fe on December 7, 2022 at 10:55:28 AM
@nihal467 Any updates on this? Please check the conversation above.
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1340782869
Shared a comment on a pull request in coronasafe/care_fe on December 4, 2022 at 4:55:50 AM
> @Ashesh3 what is the update on this PR Hey, @khavinshankar mentioned you in the review above and requested your take on what should be done here for inputs. If you could respond there and let me know, i can proceed accordingly.
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1336321863
Shared a comment on a pull request in coronasafe/care_fe on December 3, 2022 at 2:44:53 PM
> @Ashesh3 @rithviknishad > > ![Untitled](https://user-images.githubusercontent.com/57055998/205443614-dd3c383c-5fbd-479d-9e5c-83f5980ec2b8.jpg) > > the search icon is still dark and feels misaligned, it was already mentioned in a previous comment, did you forget to push the change? I accidently pushed it to my fork :/ Fixed now. ![image](https://user-images.githubusercontent.com/3626859/205444691-2efca465-bc74-4deb-a761-57f44c65cd73.png)
https://github.com/coronasafe/care_fe/pull/4071#issuecomment-1336174260
Shared a comment on a pull request in coronasafe/care_fe on December 1, 2022 at 3:52:24 PM
@gigincg @nihal467 The changes discussed on the EOD are done.
https://github.com/coronasafe/care_fe/pull/4131#issuecomment-1333976961
Shared a comment on a pull request in coronasafe/care_fe on November 30, 2022 at 1:48:14 PM
@nihal467 Yep, my bad! should be fixed now.
https://github.com/coronasafe/care_fe/pull/4071#issuecomment-1332177694
Shared a comment on an issue in coronasafe/care on November 24, 2022 at 10:25:18 AM
@vigneshhari Need your input on this.
https://github.com/coronasafe/care/issues/1107#issuecomment-1326251407
Shared a comment on a pull request in coronasafe/care_fe on November 23, 2022 at 3:30:48 PM
> @rithviknishad ![image](https://user-images.githubusercontent.com/57055998/203583305-76d65957-79e2-43af-a95f-b446f3427c0e.png) ![image](https://user-images.githubusercontent.com/57055998/203583490-9c2f60c5-1c14-46a7-9b7f-473901db63c5.png) > > * [ ] neonatal care logo in current staging and this PR is different, was it intentionally changed > > ![image](https://user-images.githubusercontent.com/57055998/203584004-266dbead-ab45-4eac-9285-4aef7e41aa1b.png) > > * [ ] the icon in the search bar, seems to be misaligned and colour is also really dark Not intentional! I will take a look.
https://github.com/coronasafe/care_fe/pull/4071#issuecomment-1325258378
Shared a comment on a pull request in coronasafe/care_fe on November 23, 2022 at 2:47:26 PM
@nihal467 Seems to work now. Can you re-test?
https://github.com/coronasafe/care_fe/pull/3964#issuecomment-1325188035
Shared a comment on a pull request in coronasafe/care_fe on November 22, 2022 at 6:18:08 AM
> @Ashesh3 you can use the `variant="secondary"` for the cancel button in the modal. Done! ![image](https://user-images.githubusercontent.com/3626859/203239194-4bf365cc-9591-4bbe-963a-200fb6956b6a.png)
https://github.com/coronasafe/care_fe/pull/4010#issuecomment-1323149588
Shared a comment on a pull request in coronasafe/care_fe on November 21, 2022 at 7:11:18 PM
@nihal467 Changes are done. Yes, the button change is intentional since we switched to ButtonV2.
https://github.com/coronasafe/care_fe/pull/4010#issuecomment-1322525464
Shared a comment on a pull request in coronasafe/care_fe on November 21, 2022 at 10:48:37 AM
Fixed.
https://github.com/coronasafe/care_fe/pull/4087#issuecomment-1321859814
Shared a comment on a pull request in coronasafe/care_fe on November 21, 2022 at 8:59:22 AM
Seems like backend changes are merged but not live yet. Waiting on that.
https://github.com/coronasafe/care_fe/pull/3964#issuecomment-1321719473
Shared a comment on an issue in coronasafe/care_fe on November 17, 2022 at 6:22:17 AM
@khavinshankar Isn't this issue resolved since we now have Facility covers?
https://github.com/coronasafe/care_fe/issues/2366#issuecomment-1318144140
Shared a comment on an issue in coronasafe/care_fe on November 17, 2022 at 6:18:42 AM
Hey @aparnacoronasafe , as per my understanding, you want the QR code generated outside CARE to point to the Transaction History of the asset stored within the CARE deployment, is that accurate? Where are these QR codes generated from?
https://github.com/coronasafe/care_fe/issues/3479#issuecomment-1318140729
Shared a comment on a pull request in coronasafe/care_fe on November 16, 2022 at 5:33:33 PM
@nihal467 Required changes are made.
https://github.com/coronasafe/care_fe/pull/4010#issuecomment-1317398049
Shared a comment on an issue in coronasafe/dashboard on November 16, 2022 at 7:16:35 AM
@aparnacoronasafe You can close the issue if it's resolved 😄
https://github.com/coronasafe/dashboard/issues/203#issuecomment-1316487543
Shared a comment on a pull request in coronasafe/care_fe on November 15, 2022 at 1:00:40 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/201910757-ec14d9bc-612b-4551-8c7b-c35e011e8143.png) > > both the buttons are misaligned with cancel button Fixed. ![image](https://user-images.githubusercontent.com/3626859/201925624-cf56606e-0631-4164-987b-623ee8fe7845.png) ![image](https://user-images.githubusercontent.com/3626859/201925708-4d27463b-2157-4fc6-b623-f740074eece0.png)
https://github.com/coronasafe/care_fe/pull/4048#issuecomment-1315277460
Shared a comment on a pull request in coronasafe/care on November 15, 2022 at 12:38:10 PM
@vigneshhari Any updates on getting this merged? 😃
https://github.com/coronasafe/care/pull/1091#issuecomment-1315253336
Shared a comment on a pull request in coronasafe/care on November 15, 2022 at 12:36:56 PM
> @Ashesh3 please make sure the lint checks are passing Fixed them!
https://github.com/coronasafe/care/pull/1091#issuecomment-1315252121
Shared a comment on a pull request in coronasafe/care_fe on November 15, 2022 at 12:07:54 PM
> @Ashesh3 > > ![image](https://user-images.githubusercontent.com/57055998/201891535-334452ee-28c6-4c2a-a919-9f0120291a61.png) > > not working is breaking in your PR It seems to work fine for me. Could you let me know the steps to reproduce the error?
https://github.com/coronasafe/care_fe/pull/4053#issuecomment-1315221006
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 2:33:24 PM
This should also resolve #3268 , can you confirm that @nihal467 ?
https://github.com/coronasafe/care_fe/pull/4010#issuecomment-1310380364
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 7:01:17 PM
> @Ashesh3 can you make a separate component or function for the validation rules, something like, > > ```js > const validationRule = (valid, content) => { > return ( > <div> > {valid ? ( > <i className="fas fa-circle-xmark text-red-500" /> > ) : ( > <i className="fas fa-circle-check text-green-500" /> > )}{" "} > <span > className={clsx( > valid > ? "text-red-500" > : "text-primary-500" > )} > > > {content} > </span> > </div> > ) > } > ``` That's a good suggestion, definitely makes the code cleaner. Done!
https://github.com/coronasafe/care_fe/pull/3934#issuecomment-1309224286
Shared a comment on an issue in coronasafe/care_fe on November 1, 2022 at 4:12:26 PM
@nihal467 can we merge this with #3886 ?
https://github.com/coronasafe/care_fe/issues/3915#issuecomment-1298771609
Shared a comment on a pull request in coronasafe/care_fe on November 1, 2022 at 3:43:07 PM
> How about using tailwind modifiers like `md:hidden md:visible` instead of useWindowDimensions hook? I think this should be the proper approach, I tried to use the above modifiers and was able to achieve the same results.
https://github.com/coronasafe/care_fe/pull/3901#issuecomment-1298730431
Shared a comment on an issue in coronasafe/care_fe on October 29, 2022 at 4:38:11 PM
Hey, it seems to be working here, the only issue being the dropdown is misaligned when facilities are selected. Is that correct? ![msedge_mrT8Y3lG08](https://user-images.githubusercontent.com/3626859/198842976-8b835c90-dfd0-452c-9b49-a53fb6641489.gif)
https://github.com/coronasafe/care_fe/issues/3871#issuecomment-1295895166
Shared a comment on an issue in coronasafe/care_fe on October 29, 2022 at 4:28:52 PM
> @Ashesh3 can you work on it ASAP Sure!
https://github.com/coronasafe/care_fe/issues/3871#issuecomment-1295892120
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 8:38:57 AM
> hey @Ashesh3, just wanted to check, this is the only code change, right? ![image](https://user-images.githubusercontent.com/29787772/197977328-69071400-e652-4053-b4f8-f8bebb20aded.png) Yes, that is correct.
https://github.com/coronasafe/care_fe/pull/3824#issuecomment-1291694375
Shared a comment on an issue in coronasafe/care_fe on October 24, 2022 at 2:01:58 PM
@nihal467 Would something like a "Session expired" popup be more user friendly than the "Invalid Token" popup? Sample: ![image](https://user-images.githubusercontent.com/3626859/197544340-aaa95c57-44d7-4462-aa15-5ea08260826e.png)
https://github.com/coronasafe/care_fe/issues/3820#issuecomment-1289084360
Shared a comment on an issue in coronasafe/care_fe on October 22, 2022 at 1:30:04 PM
> @Ashesh3 Use the new tailwind components and FilterButtons component coming via: #3744 Sure! Thanks for the heads up.
https://github.com/coronasafe/care_fe/issues/3795#issuecomment-1287793042
Shared a comment on a pull request in coronasafe/care_fe on October 22, 2022 at 7:02:12 AM
@nihal467 After discussion with Aparna, this is the finalized design: ![image](https://user-images.githubusercontent.com/3626859/197325511-7f2d5866-7092-4850-8684-6bec2ad7d8f5.png) I've made the changes to reflect the new design.
https://github.com/coronasafe/care_fe/pull/3761#issuecomment-1287654235
Shared a comment on a pull request in coronasafe/care_fe on October 21, 2022 at 5:12:56 AM
Fixed. ![image](https://user-images.githubusercontent.com/3626859/197114404-70f44f57-5dc1-4fd9-b6c5-6e87c4979f0d.png) ![image](https://user-images.githubusercontent.com/3626859/197116800-ed5ff2c6-7b7f-4bd2-b9f6-5fef4b2b315e.png) ![image](https://user-images.githubusercontent.com/3626859/197116888-9a0d073c-8ce9-410c-b430-569c73029e4e.png)
https://github.com/coronasafe/care_fe/pull/3761#issuecomment-1286470499
Shared a comment on a pull request in coronasafe/care_fe on October 20, 2022 at 12:56:05 PM
@nihal467 Done.
https://github.com/coronasafe/care_fe/pull/3748#issuecomment-1285495418
Shared a comment on a pull request in coronasafe/care_fe on October 20, 2022 at 7:23:08 AM
@nihal467 Done.
https://github.com/coronasafe/care_fe/pull/3584#issuecomment-1285063166
Shared a comment on an issue in coronasafe/care_fe on October 12, 2022 at 3:17:38 PM
Discussed on EOD. Will just keep the current behavior for now.
https://github.com/coronasafe/care_fe/issues/3712#issuecomment-1276350345
Shared a comment on a pull request in coronasafe/care_fe on October 12, 2022 at 2:33:00 PM
TODO: add back `autoprefixer` as a devdependency
https://github.com/coronasafe/care_fe/pull/3748#issuecomment-1276282942
Shared a comment on an issue in coronasafe/care_fe on October 12, 2022 at 1:10:41 PM
@aparnacoronasafe Do you want the field to be in the [1] main page or hidden in the [2] advanced patient filter section? ![image](https://user-images.githubusercontent.com/3626859/195351548-a15f7072-e21b-4d04-8276-1254beabd11c.png)
https://github.com/coronasafe/care_fe/issues/3749#issuecomment-1276151694
Shared a comment on a pull request in coronasafe/care_fe on October 11, 2022 at 2:02:54 PM
> @Ashesh3 three things: > > * [ ] Consultation updates for "Slightly Abnormal" and "Comfort Care" not working. > * [ ] New log updates page not working. > * [ ] Edit log updates not working. > > 2022-10-11.14-16-28.mp4 Should be fixed now.
https://github.com/coronasafe/care_fe/pull/3741#issuecomment-1274740988
Shared a comment on a pull request in coronasafe/care_fe on October 11, 2022 at 12:16:31 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/195082271-374b4399-bdaa-4094-86f5-bbb48138ed1e.png) > > https://deploy-preview-3699--care-net.netlify.app/facility/ee6d73a9-ac6e-4b80-a370-abce9e41d159/patient/25ea51b1-fedc-432a-a9df-9071a07862c6/consultation/1999ef08-edcd-455d-91a9-68c401209c3e/summary > > the graph is breaking in normal view It works fine here, I think the page is cached for you? Could you check again? ![gif_graph](https://user-images.githubusercontent.com/3626859/195086940-fcdebced-a817-44a7-ae19-5a43a6feae9c.gif)
https://github.com/coronasafe/care_fe/pull/3699#issuecomment-1274590878
Shared a comment on an issue in coronasafe/care_fe on October 11, 2022 at 8:11:25 AM
Is this not intentional? Since one of the cards in the last row need more height to display its contents, the rest of the cards in the same row adjust accordingly and have a uniform height, not necessarily in line with the cards in other rows. Do you have any suggestions for resolving this design?
https://github.com/coronasafe/care_fe/issues/3712#issuecomment-1274276933
Shared a comment on a pull request in coronasafe/care_fe on October 10, 2022 at 2:38:07 PM
No longer required.
https://github.com/coronasafe/care_fe/pull/3551#issuecomment-1273417220
Shared a comment on a pull request in coronasafe/care on October 10, 2022 at 2:18:47 PM
@vigneshhari Any updates on this?
https://github.com/coronasafe/care/pull/1042#issuecomment-1273388940
Shared a comment on a pull request in coronasafe/care_fe on October 6, 2022 at 10:43:27 AM
> @Ashesh3 is the issue fixed, why was this pr closed? Yep, this was fixed by @sainak on the backend and as for the frontend, @aparnacoronasafe stated removing the admitted to isn't an option so this PR is not applicable.
https://github.com/coronasafe/care_fe/pull/2659#issuecomment-1269789244
Shared a comment on a pull request in coronasafe/care_fe on October 5, 2022 at 8:09:06 PM
@nihal467 Should be fixed now.
https://github.com/coronasafe/care_fe/pull/3699#issuecomment-1268916355
Shared a comment on a pull request in coronasafe/care_fe on October 4, 2022 at 6:03:25 PM
Fixed. ![image](https://user-images.githubusercontent.com/3626859/193890091-ddca5c60-d631-46ff-8a0d-dfafe4f0ecfb.png) ![image](https://user-images.githubusercontent.com/3626859/193890125-99acd99e-b56a-4216-9338-e723013a0c22.png) ![image](https://user-images.githubusercontent.com/3626859/193892683-d7165927-9298-49fd-b727-0dbac7d9b6e3.png)
https://github.com/coronasafe/care_fe/pull/3699#issuecomment-1267365071
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 7:57:09 PM
@aparnacoronasafe I have made the required changes, a summary of the current implementation is as follows: - [X] The user is now able to set a review time in the consultation/edit consultation form or at any time in the log update form. ![image](https://user-images.githubusercontent.com/3626859/192874939-df9c8131-5337-4781-b3d5-436e847c5e21.png) - [X] When a log update is filed for the patient, the preselected review time now comes pre-filled in the 'review after' field in log update and is also available to edit on the Consultation form. Consultation Form: (Stored Value auto filled) ![image](https://user-images.githubusercontent.com/3626859/192873532-126f75c9-3840-4b27-a1e4-ca462aa5cf06.png) Daily Rounds Form: (Stored Value auto filled) ![image](https://user-images.githubusercontent.com/3626859/192873623-03a45aed-3c9e-4acb-8127-69e2d22ea8fd.png) - [X] After review time is set, then within that time if a Log Update is not filed for the patient, then the "Review Missed" Badge appears on the Patient badge, on the Patient list page, on patient summary page and on the patient details page. ![image](https://user-images.githubusercontent.com/3626859/192874704-34486105-b280-4e56-9b3d-1f9b88a22073.png) ![image](https://user-images.githubusercontent.com/3626859/192874745-dc0e4d3c-9683-45cf-b7b5-1bb1f1bfb4a0.png) ![image](https://user-images.githubusercontent.com/3626859/192874789-098339e2-5c39-4f8d-98a3-71a289157386.png) - [X] After review time is set, then the "Next review" time appears on the Patient Summary and Patient details page. ![image](https://user-images.githubusercontent.com/3626859/192874405-83470d4d-d8c0-422e-b710-6549e46131c0.png) ![image](https://user-images.githubusercontent.com/3626859/192875394-7a6e440e-f176-485b-af21-edf505c6faba.png) - [X] With every log update filed, the review clock resets to the next date according to the Review time set. ![image](https://user-images.githubusercontent.com/3626859/192875764-9a132ab7-cf6d-4806-b225-1ebdad484288.png) - [X] If the user does not edit the 'review after' field in Log Update form, the same interval will continue for review, with the review call resetting with every log update. ![image](https://user-images.githubusercontent.com/3626859/192873623-03a45aed-3c9e-4acb-8127-69e2d22ea8fd.png) Sample Workflow: - At 12:00, You file a 30 mins review time for a patient - Next review time is shown as 12:30 - You make a review at 12:15, keeping the review time as previous (30 mins) [You do have an option to change it] - Next review time automatically shows as 12:45 now (12:15 + 30 mins) - You miss the review, A "Review missed" badge is shown now since the time review was missed. - It's 1:00 now, you file a log update, but this time you decide to change the review time to 2 hours (instead of previous 30 minutes). - Now next review time shows as 3:00 (1:00 + 2 hours) - You file an update at 2:00 - Next review time shows as 4:00 now (2:00 + 2 hours)
https://github.com/coronasafe/care_fe/pull/3584#issuecomment-1261401459
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 6:51:25 AM
@mathew-alex The runs seem to be failing due to absence of `github_token`, Did you happen to remove `secrets.PERSONAL_ACCESS_TOKEN` from GitHub Action Secrets recently?
https://github.com/coronasafe/care_fe/pull/3645#issuecomment-1260465299
Shared a comment on a pull request in coronasafe/care on September 28, 2022 at 6:30:54 AM
@vigneshhari Any updates on this being merged?
https://github.com/coronasafe/care/pull/789#issuecomment-1260449196
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 6:27:31 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/192687060-c0f26485-0e18-4f20-b710-128908377ad0.png) > > even after the bed is allocated, the pop-up stays there itself, which doesn't give a good user experience Should be fixed now.
https://github.com/coronasafe/care_fe/pull/3639#issuecomment-1260446513
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 6:03:23 AM
@nihal467 That happened because this PR was quite behind the `develop` branch, merged now, the graph should be the same both sides. ![image](https://user-images.githubusercontent.com/3626859/192700065-6f920bc5-58fa-4dfc-8f0e-affb47a9e216.png)
https://github.com/coronasafe/care_fe/pull/3631#issuecomment-1260428392
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 5:54:11 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/192689388-8c077496-2360-4c02-a405-45dbcb2c71ff.png) > > lot of white space is been wasted for a single button, to better the experience, you can take an opinion in the EOD call and work on it That's totally unintentional, the delete button should be consistent with how it appears on the Users page. Should be fixed and should be just the way it is on Users page. Could you test it once again now? User Management Page: ![image](https://user-images.githubusercontent.com/3626859/192698686-308da634-6e98-4fab-8e04-c3facfae5413.png) Facility Users Page: ![image](https://user-images.githubusercontent.com/3626859/192698650-aabcecd5-7daf-4123-a00e-bcb9db70acfd.png)
https://github.com/coronasafe/care_fe/pull/3654#issuecomment-1260422596
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 5:05:04 AM
@nihal467 That shouldn't happen, this PR is pure cosmetic change, it just hides the live feed tab if the person has a discharge date. That's it. It doesn't alter anything else anywhere. It shouldn't affect the graphs at all. I'll test this once locally and with other deployments and update here.
https://github.com/coronasafe/care_fe/pull/3631#issuecomment-1260392119
Shared a comment on a pull request in coronasafe/care_fe on September 27, 2022 at 7:00:15 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/192455262-579514ed-73d5-4612-b618-ebe207e500fe.png) > > the last seen in coming down in the normal view, is it intentional Yes, that'll only happen if it can't fit the whole last seen on the same line, in rare cases of "extremely long usernames". So instead of clipping it'd shift it to the next line. All depends on the screen size and username length.
https://github.com/coronasafe/care_fe/pull/3623#issuecomment-1259069370
Shared a comment on a pull request in coronasafe/care_fe on September 26, 2022 at 2:03:21 PM
@mathew-alex We would need to manually add https://github.com/marketplace/stale to the `coronasafe` org, could you do that?
https://github.com/coronasafe/care_fe/pull/3645#issuecomment-1258091218
Shared a comment on a pull request in coronasafe/care_fe on September 25, 2022 at 1:40:45 PM
Should be fixed now: ![image](https://user-images.githubusercontent.com/3626859/192146566-e995b09d-36a0-4be6-b7d0-9bfab78a2e43.png) ![image](https://user-images.githubusercontent.com/3626859/192146584-d5d79e04-ef82-46d8-a9c1-3ae4b99ea00c.png)
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1257196839
Shared a comment on a pull request in coronasafe/care_fe on September 25, 2022 at 12:55:38 PM
> @Ashesh3 merge the latest development to this PR Done
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1257187871
Shared a comment on a pull request in coronasafe/care_fe on September 25, 2022 at 12:43:37 PM
> @Ashesh3 what is the status No changes are required to this PR. The suggested stacked table looks odd, for now the original design of this PR can be tested and implemented.
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1257185935
Shared a comment on an issue in coronasafe/care on September 23, 2022 at 5:26:14 AM
@siddnikh Hey, are you currently working on this PR?
https://github.com/coronasafe/care/issues/989#issuecomment-1255812944
Shared a comment on a pull request in coronasafe/care_fe on September 23, 2022 at 5:17:36 AM
This PR appears to be related to this issue: https://github.com/coronasafe/care_fe/issues/3366 @aparnacoronasafe suggested an archive option rather than a delete button
https://github.com/coronasafe/care_fe/pull/3495#issuecomment-1255809621
Shared a comment on an issue in coronasafe/care_fe on September 22, 2022 at 12:40:54 PM
> We should hide the Feed Tab and The Live Vitals Section for any Patient who's discharged Hey, what exactly do you mean by the feed tab? And just to confirm, is this the Live Vitals Section? ![image](https://user-images.githubusercontent.com/3626859/191749578-7fa76c58-0f12-4639-9f8e-913527a1adf6.png)
https://github.com/coronasafe/care_fe/issues/3625#issuecomment-1254967777
Shared a comment on an issue in coronasafe/care_fe on September 22, 2022 at 8:29:29 AM
> You are looking at investigation section. > > Please look at the prescription Thanks! It should be this one then, right? ![image](https://user-images.githubusercontent.com/3626859/191697865-a33deb48-f9ae-4171-9c20-e5f2da70b197.png)
https://github.com/coronasafe/care_fe/issues/3619#issuecomment-1254697881
Shared a comment on an issue in coronasafe/care_fe on September 22, 2022 at 8:02:05 AM
@aparnacoronasafe Do you mean this dropdown? ![image](https://user-images.githubusercontent.com/3626859/191691534-52b0977e-685d-4413-be3f-8874dd30d006.png) It's in Consultation.
https://github.com/coronasafe/care_fe/issues/3619#issuecomment-1254668254
Shared a comment on an issue in coronasafe/care_fe on September 19, 2022 at 12:53:45 PM
@tomahawk-pilot @gigincg Is this issue still applicable and urgent?
https://github.com/coronasafe/care_fe/issues/1629#issuecomment-1250980867
Shared a comment on an issue in coronasafe/care_fe on September 19, 2022 at 12:51:50 PM
@gigincg Is it safe to close this since #3167 is merged?
https://github.com/coronasafe/care_fe/issues/1929#issuecomment-1250978900
Shared a comment on an issue in coronasafe/care_fe on September 19, 2022 at 12:28:47 PM
@gigincg Any updates on this?
https://github.com/coronasafe/care_fe/issues/3413#issuecomment-1250954881
Shared a comment on a pull request in coronasafe/care_fe on September 16, 2022 at 1:01:36 PM
> @Ashesh3 can you check the cypress test The Failing tests are totally unrelated to the PR and as Vignesh mentioned 2 days back, Cypress tests are broken in the current state and are to be ignored until they are fixed.
https://github.com/coronasafe/care_fe/pull/3580#issuecomment-1249338771
Shared a comment on an issue in coronasafe/care_fe on September 15, 2022 at 1:51:37 PM
Wouldn't this issue be suppressed by #3587?
https://github.com/coronasafe/care_fe/issues/3591#issuecomment-1248131998
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 7:25:09 AM
> @Ashesh3 can you merge the latest develop, as there's a new mandatory field `category` added in the consultation form, hence form submission without this field would be rejected by the API. Thanks for the heads up! Done.
https://github.com/coronasafe/care_fe/pull/3584#issuecomment-1247688809
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 7:23:54 AM
- [x] make the buttons also aligned
https://github.com/coronasafe/care_fe/pull/3570#issuecomment-1247687649
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 6:45:44 AM
> @Ashesh3 can you please check out failing cypress tests Hey, the tests failing are an issue with the cypress configuration itself and @vigneshhari told us to completely ignore all Cypress tests, till they are fixed (I quote, "pretend they don't exist"). Even then, I've manually checked the tests and the failing components have nothing to do with the changes in this PR.
https://github.com/coronasafe/care_fe/pull/3569#issuecomment-1247653078
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 6:40:59 AM
@rabilrbl @aparnacoronasafe Any updates on this?
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1247649022
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 6:39:34 AM
> @Ashesh3 can you merge the latest develop branch Done.
https://github.com/coronasafe/care_fe/pull/3544#issuecomment-1247647880
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 6:37:14 AM
> > It seems like file uploads are still failing for local and netlify deployments (develop branch) but working fine on staging. > > Is it still failing? Unfortunately, yes. ![image](https://user-images.githubusercontent.com/3626859/190331989-7d641647-d84e-42ef-a015-fe81fc1841b8.png)
https://github.com/coronasafe/care_fe/pull/3580#issuecomment-1247646103
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 4:12:31 PM
It seems like file uploads are still failing for local and netlify deployments (develop branch) but working fine on staging.
https://github.com/coronasafe/care_fe/pull/3580#issuecomment-1246997816
Shared a comment on an issue in coronasafe/care_fe on September 14, 2022 at 12:28:25 PM
> @Ashesh3 the issue seem resolved, you can close it Great! Thanks for letting me know.
https://github.com/coronasafe/care_fe/issues/2984#issuecomment-1246690731
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 11:59:18 AM
@nihal467 Your internet connection isn't the issue here, it seems that the CORS misconfiguration Mathew [mentioned](https://github.com/coronasafe/care_fe/issues/3579#issuecomment-1246470517) was not resolved when you tried the upload (I had the same issue). The browser will report such errors are Network errors, since it's not able to contact the `signing_url` to upload the file due to this CORS restriction. However, this seems to have been fixed now! Could you retry the upload? If it still fails, please do send me the error logged on to the browser's console.
https://github.com/coronasafe/care_fe/pull/3580#issuecomment-1246658942
Shared a comment on an issue in coronasafe/care_fe on September 14, 2022 at 11:49:31 AM
@nihal467 I messaged you on Slack and Zoom regarding this, have you got a chance to look into this issue?
https://github.com/coronasafe/care_fe/issues/2984#issuecomment-1246648258
Shared a comment on an issue in coronasafe/care_fe on September 14, 2022 at 11:29:31 AM
It seems like according to the current workflow, an entry for a file is created before the actual upload takes place. The backend first creates an entry and returns the signed_url which is used on the frontend side to make the actual upload. If the upload fails, the backend has no way of knowing the same and frontend does nothing to remedy that. Possible fix: Currently all files have an attribute `upload_completed` which defaults to `False`. Once an upload is actually successful, the frontend can send a separate request to set that to `True`. The file list on the frontend would then only show files which have `upload_completed = True`. @vigneshhari What's your take on this?
https://github.com/coronasafe/care_fe/issues/3582#issuecomment-1246629016
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 11:07:00 AM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/190124995-116c82ea-b97b-41a4-b4a9-1b0ec3a0f574.png) > > now the page is auto-refreshed, but the file name is still there under the box, can you fix that also That should only happen if the file upload fails, I've added an error message when that happens. ![image](https://user-images.githubusercontent.com/3626859/190131758-b5753df7-d014-448a-bf06-da16c94c9eae.png)
https://github.com/coronasafe/care_fe/pull/3580#issuecomment-1246605044
Shared a comment on an issue in coronasafe/care_fe on September 14, 2022 at 8:34:57 AM
@nihal467 The linked PR should fix the 1st issue: - [x] after the file is uploaded, we have to manually reload the page to see the reflection For the other issue, it seems that there's a misconfiguration from the AWS side of things, Someone with AWS access needs to take a look there. The key seems to have been removed? `NoSuchKey`. @gigincg Can you take a look into this?
https://github.com/coronasafe/care_fe/issues/3579#issuecomment-1246429466
Shared a comment on a pull request in coronasafe/care_fe on September 12, 2022 at 5:22:07 PM
> @Ashesh3 merge the latest development branch Done!
https://github.com/coronasafe/care_fe/pull/3550#issuecomment-1244059318
Shared a comment on a pull request in coronasafe/care_fe on September 12, 2022 at 5:21:23 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/189691174-fa4172e1-0b30-4c1f-80c6-c6d7762aa596.png) > > * [ ] make the buttons also aligned > * [ ] the admit and confirm both buttons size are bit feel increase, was it intentional The admit and confirm buttons have minor padding added to them and rounded the shape. This makes them looks better especially on smaller screens, otherwise the text touches the border of the button. I will make the buttons aligned.
https://github.com/coronasafe/care_fe/pull/3570#issuecomment-1244058461
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 1:22:28 PM
@aparnacoronasafe Any updates on this? What should be the ideal length of the name?
https://github.com/coronasafe/care_fe/issues/3513#issuecomment-1242964067
Shared a comment on an issue in coronasafe/care on September 11, 2022 at 1:12:20 PM
@gigincg can we close this?
https://github.com/coronasafe/care/issues/474#issuecomment-1242962124
Shared a comment on an issue in coronasafe/care on September 11, 2022 at 1:12:12 PM
Seems like category is removed from the frontend. https://github.com/coronasafe/care_fe/commit/2987f5f2753233f4f7b8a1b8833acbac8e894be9
https://github.com/coronasafe/care/issues/474#issuecomment-1242962083
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 1:04:13 PM
@gigincg Seems like intentional behavior. Does this issue still apply?
https://github.com/coronasafe/care_fe/issues/3413#issuecomment-1242960735
Shared a comment on an issue in coronasafe/care on September 11, 2022 at 1:00:49 PM
@gigincg Was this issue reopened by mistake?
https://github.com/coronasafe/care/issues/609#issuecomment-1242960116
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 12:54:04 PM
Seems like the currently both Admission Date and Decision after Consultation are editable fields. I am able to change them without issue on staging. Does this issue still apply? @patelaryan7751 can you check if this is resolved now?
https://github.com/coronasafe/care_fe/issues/2747#issuecomment-1242958896
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 12:33:19 PM
> @Ashesh3 shall I assign it to you then? I didn't make much changes yet. Sure! I already have the fix with me ready since I fixed the same thing before.. Thanks.
https://github.com/coronasafe/care_fe/issues/3571#issuecomment-1242955156
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 12:13:51 PM
This is sad :( I specifically fixed this bug in https://github.com/coronasafe/care_fe/pull/3452 but then someone overwrote my changes? Not sure what happened but the same bug was bought back to life in this commit: https://github.com/coronasafe/care_fe/commit/6268a39ef7d11469925b6e7c905ffedbe6cc8807
https://github.com/coronasafe/care_fe/issues/3571#issuecomment-1242951685
Shared a comment on a pull request in coronasafe/care on September 9, 2022 at 9:10:33 AM
Fixes https://github.com/coronasafe/care_fe/issues/3561
https://github.com/coronasafe/care/pull/1013#issuecomment-1241713890
Shared a comment on an issue in coronasafe/care_fe on September 8, 2022 at 9:45:51 PM
@gigincg any updates regarding what should be done with this issue?
https://github.com/coronasafe/care_fe/issues/2747#issuecomment-1241266159
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 2:42:13 PM
> @Ashesh3 @khavinshankar it is working now, do we need this PR or close it? We still need this PR to fix it, This adds a conditional check to not print attributes which do not exist. This should make the care platform more robust and crash proof. This will ensure that crashes do not happen in future even if backend and frontend are not in sync.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239484963
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 1:35:53 PM
> @Ashesh3 Reached out to @gigincg told me @aparnacoronasafe Will confirm whether this UI is confusing or not. Sure! Please do let me know here once you have an update on that.
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1239400387
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 8:18:44 AM
@khavinshankar The backend does have proper validation for feature ids. This issue seemed to be due to an inconsistency between the features mapping on the backend and frontend. Backend: ``` FEATURE_CHOICES = [ (1, "CT Scan Facility"), (2, "Maternity Care"), (3, "X-Ray facility"), (4, "Neonatal care"), (5, "Operation theater"), (6, "Blood Bank"), ] ``` Frontend: ``` export const FACILITY_FEATURE_TYPES = [ { id: 1, name: "CT Scan", icon: "circle-dot", }, { id: 2, name: "Maternity Care", icon: "person-breastfeeding", }, { id: 3, name: "X-Ray", icon: "x-ray", }, { id: 4, name: "Neonatal Care", icon: "baby", }, { id: 5, name: "Operation Theater", icon: "syringe", }, ]; ``` Feature "Blood Bank" with id `6` has not been added to the frontend yet. Issue (Addition of Blood Bank): https://github.com/coronasafe/care_fe/issues/3469 The below two PRs ideally should have been merged together: Backend change: https://github.com/coronasafe/care/pull/993 Frontend change: https://github.com/coronasafe/care_fe/pull/3474 But it seems that the backend change was merged but the frontend lagged behind, which caused this issue.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239064727
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 8:06:07 AM
> @Ashesh3 can you please raise an issue about this in the backend? Sure!
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239051392
Shared a comment on an issue in coronasafe/care_fe on September 7, 2022 at 7:52:09 AM
> @nihal467 the issue was due to that, there was a facility that had a feature that was not there in our pre-defined list of features ![image](https://user-images.githubusercontent.com/29787772/188820763-26f017ee-04d4-49ee-92fc-09ad57fcc9ed.png) Exactly! Any idea how could an invalid feature was set for this facility? https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239032458
https://github.com/coronasafe/care_fe/issues/3552#issuecomment-1239037330
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:47:21 AM
@nihal467 Should be fixed now. Somehow the facility "test-nihal-001" has a feature which doesn't exist (ID 6). This shouldn't be possible as the frontend has no option to set a feature with ID 6 during asset creation. Maybe there needs to be checks on the backend to disallow such invalid values.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239032458
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:20:36 AM
@rabilrbl Which design looks better for you?
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1239005880
Shared a comment on an issue in coronasafe/care_fe on September 7, 2022 at 7:06:45 AM
@nihal467 resolved, please test.
https://github.com/coronasafe/care_fe/issues/3552#issuecomment-1238993408
Shared a comment on an issue in coronasafe/dashboard on September 7, 2022 at 4:53:36 AM
> Patient numbers appearing for MAJ Hospital is all off on patient export. > > CARE shows 24 live patients in the hospital. But the CSV export only shows 4 patients in the isolation rooms and 0 is all other bed types. In CARE there are 7 patients in the isolation room and a total of 24 live patients. > > The same thing may be happening for other facilities as well. > > [patient_export.csv](https://github.com/coronasafe/dashboard/files/6569282/patient_export.csv) I am unable to reproduce this issue, can you check if this still exists?
https://github.com/coronasafe/dashboard/issues/144#issuecomment-1238906568
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 2:42:13 PM
> @Ashesh3 @khavinshankar it is working now, do we need this PR or close it? We still need this PR to fix it, This adds a conditional check to not print attributes which do not exist. This should make the care platform more robust and crash proof. This will ensure that crashes do not happen in future even if backend and frontend are not in sync.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239484963
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 1:35:53 PM
> @Ashesh3 Reached out to @gigincg told me @aparnacoronasafe Will confirm whether this UI is confusing or not. Sure! Please do let me know here once you have an update on that.
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1239400387
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 8:18:44 AM
@khavinshankar The backend does have proper validation for feature ids. This issue seemed to be due to an inconsistency between the features mapping on the backend and frontend. Backend: ``` FEATURE_CHOICES = [ (1, "CT Scan Facility"), (2, "Maternity Care"), (3, "X-Ray facility"), (4, "Neonatal care"), (5, "Operation theater"), (6, "Blood Bank"), ] ``` Frontend: ``` export const FACILITY_FEATURE_TYPES = [ { id: 1, name: "CT Scan", icon: "circle-dot", }, { id: 2, name: "Maternity Care", icon: "person-breastfeeding", }, { id: 3, name: "X-Ray", icon: "x-ray", }, { id: 4, name: "Neonatal Care", icon: "baby", }, { id: 5, name: "Operation Theater", icon: "syringe", }, ]; ``` Feature "Blood Bank" with id `6` has not been added to the frontend yet. Issue (Addition of Blood Bank): https://github.com/coronasafe/care_fe/issues/3469 The below two PRs ideally should have been merged together: Backend change: https://github.com/coronasafe/care/pull/993 Frontend change: https://github.com/coronasafe/care_fe/pull/3474 But it seems that the backend change was merged but the frontend lagged behind, which caused this issue.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239064727
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 8:06:07 AM
> @Ashesh3 can you please raise an issue about this in the backend? Sure!
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239051392
Shared a comment on an issue in coronasafe/care_fe on September 7, 2022 at 7:52:09 AM
> @nihal467 the issue was due to that, there was a facility that had a feature that was not there in our pre-defined list of features ![image](https://user-images.githubusercontent.com/29787772/188820763-26f017ee-04d4-49ee-92fc-09ad57fcc9ed.png) Exactly! Any idea how could an invalid feature was set for this facility? https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239032458
https://github.com/coronasafe/care_fe/issues/3552#issuecomment-1239037330
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:47:21 AM
@nihal467 Should be fixed now. Somehow the facility "test-nihal-001" has a feature which doesn't exist (ID 6). This shouldn't be possible as the frontend has no option to set a feature with ID 6 during asset creation. Maybe there needs to be checks on the backend to disallow such invalid values.
https://github.com/coronasafe/care_fe/pull/3553#issuecomment-1239032458
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:20:36 AM
@rabilrbl Which design looks better for you?
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1239005880
Shared a comment on an issue in coronasafe/care_fe on September 7, 2022 at 7:06:45 AM
@nihal467 resolved, please test.
https://github.com/coronasafe/care_fe/issues/3552#issuecomment-1238993408
Shared a comment on an issue in coronasafe/dashboard on September 7, 2022 at 4:53:36 AM
> Patient numbers appearing for MAJ Hospital is all off on patient export. > > CARE shows 24 live patients in the hospital. But the CSV export only shows 4 patients in the isolation rooms and 0 is all other bed types. In CARE there are 7 patients in the isolation room and a total of 24 live patients. > > The same thing may be happening for other facilities as well. > > [patient_export.csv](https://github.com/coronasafe/dashboard/files/6569282/patient_export.csv) I am unable to reproduce this issue, can you check if this still exists?
https://github.com/coronasafe/dashboard/issues/144#issuecomment-1238906568
Shared a comment on a pull request in coronasafe/care_fe on September 6, 2022 at 12:16:30 PM
> Why isn't the package-lock changed? Apologies for the confusion, Added now!
https://github.com/coronasafe/care_fe/pull/3544#issuecomment-1238068608
Shared a comment on a pull request in coronasafe/care_fe on September 6, 2022 at 4:58:43 AM
> Why isn't the package-lock changed? That's a good question! Since we're using Yarn as our primary package manager, I've removed and added packages solely using `yarn` commands. It does not touch package-lock, instead it has it's own lock file `yarn.lock` which was indeed modified during this migration. So why isn't it there in this PR? 🤔 It's apparently ignored in the `.gitignore` file [here](https://github.com/coronasafe/care_fe/blob/develop/.gitignore#L52). It was recently added in [this commit](https://github.com/coronasafe/care_fe/commit/6e53406f168d005caa5ba4a9747dd4bf25e2b320#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R50-R52) (probably unintentionally) Ideally, it should be checked out to source control. https://classic.yarnpkg.com/en/docs/migrating-from-npm > When you run either yarn or yarn add <package>, Yarn will generate a yarn.lock file within the root directory of your package. You don’t need to read or understand this file - just check it into source control. When other people start using Yarn instead of npm, the yarn.lock file will ensure that they get precisely the same dependencies as you have. I made a PR resolving the above issue here: #3545
https://github.com/coronasafe/care_fe/pull/3544#issuecomment-1237659849
Shared a comment on a pull request in coronasafe/care_fe on September 5, 2022 at 9:05:43 PM
> @Ashesh3 The UI is a bit confusing in small screens Can we have flex-col so that fields stack in mobile devices? I agree that the table is a bit hard to navigate on smaller screens but I am afraid I am aware of no better solution. MaterialUI Table does not allow us to display the cells stacked according to the screen size. https://mui.com/material-ui/api/table/ Although we can indeed force the cells to stack, this might not achieve the best results: ![image](https://user-images.githubusercontent.com/3626859/188512255-dff811d3-69dd-4d3c-ba16-316ea0ccdaf2.png) I believe that at it's current state (with this PR), it makes the table at least fully usable and represents it in an elegant manner. If you know of any better way, feel free to suggest a change!
https://github.com/coronasafe/care_fe/pull/3539#issuecomment-1237456166
Shared a comment on an issue in coronasafe/care_fe on September 5, 2022 at 5:46:14 AM
@nihal467 Any info on this?
https://github.com/coronasafe/care_fe/issues/2984#issuecomment-1236562085
Shared a comment on a pull request in coronasafe/care on September 4, 2022 at 4:19:20 AM
Added caching the asset for 24 hours by it's `external_id` and invalidating it on the `save` method. ``` CACHE MISS [04/Sep/2022 09:41:20] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 838 CACHE HIT [04/Sep/2022 09:41:24] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 838 CACHE HIT [04/Sep/2022 09:41:25] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 838 CACHE HIT [04/Sep/2022 09:41:28] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 838 CACHE INVALIDATED INFO 2022-09-04 09:41:37,580 receivers 1378112 281472209514784 AUDIT_LOG::put::7ab4a38924973defbfad1b5d484bcc29::20e5b23c0e0a46e1b8f00674ee50619b|devdistrictadmin|update|facility.Asset|ID:1|{"name": "Testttttt122dddddd12"} INFO 2022-09-04 09:41:37,618 middleware 1378112 281472209514784 PUT /api/v1/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ 200 User:[4|devdistrictadmin] [04/Sep/2022 09:41:37] "PUT /api/v1/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 840 CACHE MISS [04/Sep/2022 09:43:52] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 840 CACHE HIT [04/Sep/2022 09:43:58] "GET /api/v1/public/asset/b8b71bff-7cf0-4fad-9180-7fc79f2b060d/ HTTP/1.1" 200 840 ```
https://github.com/coronasafe/care/pull/998#issuecomment-1236256551
Shared a comment on an issue in coronasafe/care_fe on September 3, 2022 at 5:43:46 PM
@nihal467 yep that should resolve it!
https://github.com/coronasafe/care_fe/issues/3532#issuecomment-1236170648
Shared a comment on a pull request in coronasafe/care_fe on September 3, 2022 at 6:21:22 AM
Made the changes. ![image](https://user-images.githubusercontent.com/3626859/188258518-867e802c-8013-4bbe-9239-1c80186dff16.png) On hover: ![msedge_b7bxCFuqe2](https://user-images.githubusercontent.com/3626859/188258595-037e0ae2-8441-42f2-8710-a477d3c5f6ac.gif)
https://github.com/coronasafe/care_fe/pull/3503#issuecomment-1236058719
Shared a comment on a pull request in coronasafe/leaderboard on September 1, 2022 at 4:36:12 PM
+1
https://github.com/coronasafe/leaderboard/pull/77#issuecomment-1234521005
Shared a comment on a pull request in coronasafe/care_fe on August 31, 2022 at 2:43:23 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/187697750-2ac37954-a936-4b92-b889-9d7dfa3cdb15.png) > > The sample report button is a bit bigger in normal view, compared to the other buttons, can you check it? Should be fixed now. ![image](https://user-images.githubusercontent.com/3626859/187706638-2e1ecbdd-cb0e-48e5-9027-8fb25bd240e7.png) ![image](https://user-images.githubusercontent.com/3626859/187707013-debc1119-154f-438d-b20e-6f5771c2aa4b.png)
https://github.com/coronasafe/care_fe/pull/3511#issuecomment-1233032878
Shared a comment on an issue in coronasafe/care_fe on August 27, 2022 at 7:19:13 AM
Seems duplicate of https://github.com/coronasafe/care_fe/issues/2642 PR Fixing this: https://github.com/coronasafe/care_fe/pull/2659
https://github.com/coronasafe/care_fe/issues/3482#issuecomment-1229140908
Shared a comment on a pull request in coronasafe/care_fe on August 24, 2022 at 10:07:05 AM
@nihal467 made some changes, attached the recordings for both scenarios. ## Original https://care.coronasafe.in/assets/5f659f66-648d-4c6b-8a20-a9e8366980a1/configure ![chrome_jSXoYW2DHP](https://user-images.githubusercontent.com/3626859/186391695-63eb8e22-c2fd-41b0-98c3-8c37314ddda8.gif) No error is shown even though fetching the preset has failed. ## With this PR: https://deploy-preview-3186--care-egov-staging.netlify.app/assets/5f659f66-648d-4c6b-8a20-a9e8366980a1/configure ![chrome_fEXiggwzYB](https://user-images.githubusercontent.com/3626859/186391498-1d10fe30-b4b8-4460-a5fb-2d9e5ae72713.gif)
https://github.com/coronasafe/care_fe/pull/3186#issuecomment-1225507933
Shared a comment on a pull request in coronasafe/care_fe on August 23, 2022 at 10:38:26 AM
@mathew-alex @khavinshankar Done.
https://github.com/coronasafe/care_fe/pull/3395#issuecomment-1223883734
Shared a comment on a pull request in coronasafe/care_fe on August 23, 2022 at 10:31:57 AM
> @Ashesh3 check the merge conflict Hey, did you mean to mention @skks1212 ?
https://github.com/coronasafe/care_fe/pull/3363#issuecomment-1223877589
Shared a comment on a pull request in coronasafe/care_fe on August 19, 2022 at 6:24:42 AM
@khavinshankar Thank you for the suggestions, I have implemented them.
https://github.com/coronasafe/care_fe/pull/3389#issuecomment-1220298926
Shared a comment on a pull request in coronasafe/care_fe on August 16, 2022 at 1:54:02 PM
> @Ashesh3 create a separate issue and resolve it there @nihal467 Done here https://github.com/coronasafe/care_fe/pull/3417
https://github.com/coronasafe/care_fe/pull/3247#issuecomment-1216671115
Shared a comment on a pull request in coronasafe/care_fe on August 16, 2022 at 1:15:04 PM
@nihal467 Fixed. ![msedge_21hsNLrep5](https://user-images.githubusercontent.com/3626859/184888362-f080c823-d6e3-4c0e-8ffe-75b940324e13.gif)
https://github.com/coronasafe/care_fe/pull/3346#issuecomment-1216623480
Shared a comment on a pull request in coronasafe/care_fe on August 16, 2022 at 9:20:32 AM
@nihal467 It seems like a backend issue having trouble filtering patients. Would it be okay if I create a separate backend issue to resolve that? This PR just changes UI styling of download button, nothing else. We should be able to test and merge this PR and resolve the issue you mentioned separately.
https://github.com/coronasafe/care_fe/pull/3247#issuecomment-1216377012
Shared a comment on a pull request in coronasafe/care_fe on August 15, 2022 at 2:50:35 PM
@nihal467 Fixed. ![image](https://user-images.githubusercontent.com/3626859/184658363-c778c606-13b8-429a-b608-f417dff2dd74.png) ![image](https://user-images.githubusercontent.com/3626859/184658416-ee88eaba-4e31-4144-8248-64e427717958.png)
https://github.com/coronasafe/care_fe/pull/3346#issuecomment-1215100939
Shared a comment on an issue in coronasafe/care_fe on August 14, 2022 at 3:55:52 PM
Bed Management has the same issue. ![image](https://user-images.githubusercontent.com/3626859/184544999-4b6a6b3a-17dc-4a11-b0ed-bc1aaf21e589.png)
https://github.com/coronasafe/care_fe/issues/3391#issuecomment-1214405274
Shared a comment on an issue in coronasafe/care_fe on August 12, 2022 at 12:43:27 PM
> @Ashesh3 the issue is there, I think @nihal467 missed one step, edited the description. Also, refer to this: ![redirection error](https://user-images.githubusercontent.com/42417893/184260805-580d6ba6-50e1-44ba-89a8-b42122e5c9f9.gif) [ ![redirection error](https://user-images.githubusercontent.com/42417893/184260805-580d6ba6-50e1-44ba-89a8-b42122e5c9f9.gif) ](https://user-images.githubusercontent.com/42417893/184260805-580d6ba6-50e1-44ba-89a8-b42122e5c9f9.gif) [ ](https://user-images.githubusercontent.com/42417893/184260805-580d6ba6-50e1-44ba-89a8-b42122e5c9f9.gif) Thanks for the clarification!
https://github.com/coronasafe/care_fe/issues/3304#issuecomment-1213072153
Shared a comment on an issue in coronasafe/care_fe on August 11, 2022 at 9:41:13 AM
> @aparnacoronasafe Only the COVID Positive Badge is retained. The following are being removed > > * Contact with confirmed carrier > * Contact with suspected carrier > * Recovered > * Negative That's correct, the current PR only retains the COVID Positive Badge.
https://github.com/coronasafe/care_fe/issues/3325#issuecomment-1211759982
Shared a comment on an issue in coronasafe/care_fe on August 10, 2022 at 7:59:50 PM
@nihal467 I am unable to replicate this issue. 1. Discharged patient from facility A, ![image](https://user-images.githubusercontent.com/3626859/184008617-6edf8a0f-297b-48ba-8376-20bda2d4628d.png) 2. Readmitted the patient to facility A, ![image](https://user-images.githubusercontent.com/3626859/184008676-d1fbd1b9-9a0e-44f7-9f2e-8a07ad35f277.png) The medical history is preserved for me here. Edit Patient details (after readmitting): ![image](https://user-images.githubusercontent.com/3626859/184008785-405198fd-fa5d-4833-a2fe-53898f9a6200.png)
https://github.com/coronasafe/care_fe/issues/2984#issuecomment-1211204692
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 10:44:24 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/183769124-e9723eee-355c-48d4-abfe-acbf6306de58.png) > > the file name of a PDF is different in care and download Hey, I am unable to replicate this issue. The file downloads correctly for me, with the correct file name. https://deploy-preview-3303--care-egov-staging.netlify.app/facility/bd466cf6-0fde-46b1-9591-0acf9d955dd1/patient/163c6459-d121-4814-9ef4-4ef35937711f/files/ ![image](https://user-images.githubusercontent.com/3626859/183774158-66004fee-b44c-45a5-b5a5-3f0416d59b2d.png) Could you take a look at this again? If the issue persist, please let me know the steps which lead to the issue.
https://github.com/coronasafe/care_fe/pull/3303#issuecomment-1209965425
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 10:10:05 PM
> 3286 Hey, I am unable to replicate the issue on my end, pdf files are correctly downloaded with the name of the file. Could you tell me the patient url for the screenshot you provided?
https://github.com/coronasafe/care_fe/pull/3303#issuecomment-1209942343
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 9:55:05 PM
> @Ashesh3 ![image](https://user-images.githubusercontent.com/57055998/183768355-bcbf1319-88c4-46de-9602-326487ff3c62.png) > > i can only find this error, @khavinshankar can you check this ! I think this error is related to saving the configuration, and not while fetching presets. To trigger the preset error, save the asset with blank hostname, address and key.
https://github.com/coronasafe/care_fe/pull/3186#issuecomment-1209931965
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 2:38:42 PM
This seems to be fixed from the backend, can test again now.
https://github.com/coronasafe/care_fe/pull/3247#issuecomment-1209468655
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 1:59:05 PM
@nihal467 It seems there is a backend issue currently causing the download to fail. The downloads are failing on the staging too, even without this PR. Waiting for the backend issue to be fixed.
https://github.com/coronasafe/care_fe/pull/3247#issuecomment-1209420386
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2022 at 1:41:57 PM
> @Ashesh3 > > ![image](https://user-images.githubusercontent.com/57055998/183655212-1083a4c9-4c3d-4a63-949f-20a64b5e608a.png) > > this stressed three button is three-row doesn't look good, feel the old view is better, take a opinion from @gigincg That seems to be a bug! Didn't intend for it to look like that on large screens. Fixed it now.
https://github.com/coronasafe/care_fe/pull/3357#issuecomment-1209399025
Shared a comment on a pull request in coronasafe/care_fe on August 8, 2022 at 8:24:50 PM
@gigincg Discussed changes are done. Only positive badges are shown with the text, "COVID Positive" ![image](https://user-images.githubusercontent.com/3626859/183507794-2923ebac-60cd-4210-9d4e-c1be4da43db8.png)
https://github.com/coronasafe/care_fe/pull/3318#issuecomment-1208574715
Shared a comment on a pull request in coronasafe/care_fe on August 8, 2022 at 7:29:28 PM
> I missed your earlier comment, 😅 just noticed it's already fixed, good to close!
https://github.com/coronasafe/care_fe/pull/3218#issuecomment-1208523747
Shared a comment on a pull request in coronasafe/care_fe on August 7, 2022 at 6:11:55 PM
@nihal467 This PR just disables the button to add new volunteer, the backend change fixing the issue is a separate PR, not related to this, https://github.com/coronasafe/care/pull/959
https://github.com/coronasafe/care_fe/pull/3290#issuecomment-1207458994
Shared a comment on a pull request in coronasafe/care_fe on August 7, 2022 at 1:27:42 PM
@nihal467 Fixed! ![image](https://user-images.githubusercontent.com/3626859/183293050-017dacfc-c245-41c2-a0db-ca73f2715ab5.png)
https://github.com/coronasafe/care_fe/pull/3184#issuecomment-1207408629
Shared a comment on a pull request in coronasafe/care_fe on August 6, 2022 at 8:47:11 AM
Renamed Alt phone to WhatsApp phone on the filters page, to maintain consistency. ![image](https://user-images.githubusercontent.com/3626859/183241962-59303f0b-2e4e-4fc1-aa0d-338b20f4d410.png)
https://github.com/coronasafe/care_fe/pull/3184#issuecomment-1207176596
Shared a comment on an issue in coronasafe/care_fe on August 5, 2022 at 7:18:26 AM
@aparnacoronasafe PR https://github.com/coronasafe/care_fe/pull/3318/ already fixes this issue! Linked this issue to said PR.😄
https://github.com/coronasafe/care_fe/issues/3325#issuecomment-1206126678
Shared a comment on a pull request in coronasafe/care_fe on August 5, 2022 at 7:18:16 AM
Also fixes #3325 https://github.com/coronasafe/care_fe/pull/3318/files#diff-6a60fce2df893cf91c0457f6445b903c1d6667b6a86fc21c38a9e8fc385c7575L566
https://github.com/coronasafe/care_fe/pull/3318#issuecomment-1206126582
Shared a comment on an issue in coronasafe/care_fe on August 4, 2022 at 5:04:51 PM
@nihal467 Hey, I am unable to replicate this issue. Could you check if this issue is still present? ![](https://user-images.githubusercontent.com/3626859/182908820-21bb025a-b938-4d01-aef7-ad64c08f1ca5.gif)
https://github.com/coronasafe/care_fe/issues/3304#issuecomment-1205532369
Shared a comment on a pull request in coronasafe/care_fe on August 3, 2022 at 12:20:33 PM
Dependent PR: https://github.com/coronasafe/care/pull/924
https://github.com/coronasafe/care_fe/pull/2659#issuecomment-1203876461
Shared a comment on a pull request in coronasafe/care_fe on August 1, 2022 at 8:55:19 PM
@nihal467 Done ![image](https://user-images.githubusercontent.com/3626859/182245019-a306b231-4128-4833-980d-8618420f981b.png)
https://github.com/coronasafe/care_fe/pull/3271#issuecomment-1201710687
Shared a comment on a pull request in coronasafe/care_fe on August 1, 2022 at 4:26:35 PM
@nihal467 Done ![image](https://user-images.githubusercontent.com/3626859/182197617-9677cef1-3dc5-4b7d-80ee-9897e5c09982.png)
https://github.com/coronasafe/care_fe/pull/3270#issuecomment-1201432339
Shared a comment on a pull request in coronasafe/care_fe on July 31, 2022 at 5:27:42 AM
> @Ashesh3 what is the PR status Backend change was merged, We can proceed to test out this PR.
https://github.com/coronasafe/care_fe/pull/2659#issuecomment-1200352125
Shared a comment on a pull request in coronasafe/care_fe on July 31, 2022 at 5:24:04 AM
> @Ashesh3 what is the current status of the PR The backend change was approved but hasn't been merged yet. Waiting for it to be merged before we can proceed with testing this PR.
https://github.com/coronasafe/care_fe/pull/2536#issuecomment-1200351790
Shared a comment on an issue in coronasafe/care_fe on July 30, 2022 at 9:49:07 PM
@nihal467 The expected behaviour here would be that the volunteer is unassigned when the patient is discharged, is that correct?
https://github.com/coronasafe/care_fe/issues/3272#issuecomment-1200299565
Shared a comment on a pull request in coronasafe/care_fe on July 29, 2022 at 6:43:14 AM
The requested changes are done, need a test now!
https://github.com/coronasafe/care_fe/pull/3200#issuecomment-1198935293
Shared a comment on a pull request in coronasafe/care_fe on July 28, 2022 at 2:14:20 PM
Todo: After discussing this with @gigincg , The change would be to rename "Alternative number" on the filter page to "WhatsApp number"
https://github.com/coronasafe/care_fe/pull/3184#issuecomment-1198200520
Shared a comment on a pull request in coronasafe/care_fe on July 26, 2022 at 3:12:10 PM
> @Ashesh3 test failed ![image](https://user-images.githubusercontent.com/57055998/180970896-cdb4443c-6b53-4e0c-b4db-fd1dcd0515cd.png) > > it is showing in the patient tab > > https://deploy-preview-3215--care-net.netlify.app/facility/bd466cf6-0fde-46b1-9591-0acf9d955dd1/patient/8027c51f-f6bf-449f-81a2-1c1fba999ac0 Should be fixed now.
https://github.com/coronasafe/care_fe/pull/3215#issuecomment-1195612392
Shared a comment on a pull request in coronasafe/care_fe on July 26, 2022 at 7:49:13 AM
@coronasafe/care-fe-code-reviewers Need your opinion here.
https://github.com/coronasafe/care_fe/pull/3184#issuecomment-1195130538
Shared a comment on a pull request in coronasafe/care_fe on July 26, 2022 at 6:37:59 AM
@nihal467 Fixed it so that antenatal badge and details are only displayed on the Patient detail page when the sex is female.
https://github.com/coronasafe/care_fe/pull/3215#issuecomment-1195067608
Shared a comment on a pull request in coronasafe/care_fe on July 26, 2022 at 6:26:20 AM
The requested changes are made from my side and it works as expected. Need testing now.
https://github.com/coronasafe/care_fe/pull/3200#issuecomment-1195058217
Shared a comment on a pull request in coronasafe/care_fe on July 24, 2022 at 8:12:14 PM
Fixed. ![](https://user-images.githubusercontent.com/3626859/180664122-b36e35fe-bc4e-4ff0-9976-43f0d3697ef8.gif)
https://github.com/coronasafe/care_fe/pull/2614#issuecomment-1193386515
Shared a comment on an issue in coronasafe/care_fe on July 23, 2022 at 1:29:22 PM
The facility actually does get created, just the success message is not shown here.
https://github.com/coronasafe/care_fe/issues/3207#issuecomment-1193126015
Shared a comment on a pull request in coronasafe/care_fe on July 22, 2022 at 6:39:19 AM
> @Ashesh3 can you mention the issue? Alternative numbers and WhatsApp numbers are two different things. They appear to be the same thing. We can set WhatsApp number on the profile page, but in the users page, the filter lists it as "Alternative number" and filtering works displaying it as alt number ![image](https://user-images.githubusercontent.com/3626859/180377350-7da2e812-704d-4f5b-9bd6-b4fda957b51b.png) ![image](https://user-images.githubusercontent.com/3626859/180377361-c6a47e10-0400-44cd-9377-7992b6bb2bfc.png) But the profile page shows it as "WhatsApp" number. ![image](https://user-images.githubusercontent.com/3626859/180377424-8b9e6aaa-3808-443a-bc8f-87553587b56c.png) The frontend is inconsistent with how the data is stored and represented in the backend. Everywhere, the "second number" is referenced by "Alternative number" and not "WhatsApp number". https://github.com/coronasafe/care/blob/master/care/users/models.py#L216 ``` class User(AbstractUser): ... alt_phone_number = models.CharField ``` The filter displays it as "Alternative number" too ![image](https://user-images.githubusercontent.com/3626859/180378230-0734a749-598c-44a0-ab5c-18060cfd5800.png) Updating the said "WhatsApp number" actually sends it as the alternative number: ![image](https://user-images.githubusercontent.com/3626859/180378368-e336a954-47e0-4c9f-ad08-23699b52490c.png) https://github.com/coronasafe/care_fe/blob/develop/src/Components/Users/UserProfile.tsx#L491 ``` <PhoneNumberField --> name="altPhoneNumber" label="Whatsapp Number" --> value={states.form.altPhoneNumber} onChange={ (value: string) => --> handleWhatsappNumChange(value, "altPhoneNumber") } errors={states.errors.altPhoneNumber} /> ``` So, it appears that "WhatsApp number" is actually just the "Alternative number" but mislabeled.
https://github.com/coronasafe/care_fe/pull/3184#issuecomment-1192237461
Shared a comment on an issue in coronasafe/care_fe on July 21, 2022 at 6:40:07 PM
Duplicate of https://github.com/coronasafe/care_fe/issues/2440 ?
https://github.com/coronasafe/care_fe/issues/3147#issuecomment-1191814955
Shared a comment on a pull request in coronasafe/care_fe on July 19, 2022 at 6:34:24 AM
@nihal467 Should be more responsive now: 300px width ![image](https://user-images.githubusercontent.com/3626859/179681688-f5019d79-00ba-4f0d-bae4-e6f538196288.png)
https://github.com/coronasafe/care_fe/pull/2614#issuecomment-1188655057
Shared a comment on an issue in coronasafe/care_fe on July 11, 2022 at 9:37:24 PM
@nihal467 This should be fixed in https://github.com/coronasafe/care_fe/commit/63e2ffa0a6f98c9f4fb530ecafd4d509ba36489e ![image](https://user-images.githubusercontent.com/3626859/178362849-42c01541-14dd-4c1a-9bcc-96c4e807bbdf.png)
https://github.com/coronasafe/care_fe/issues/3092#issuecomment-1180895028
Shared a comment on an issue in coronasafe/care_fe on July 11, 2022 at 9:17:47 PM
@nihal467 This is due to https://github.com/coronasafe/care_fe/pull/2947 not being merged even though the backend change for the same was recently merged and is live. Merged backend PR: https://github.com/coronasafe/care/pull/902
https://github.com/coronasafe/care_fe/issues/3101#issuecomment-1180879648
Shared a comment on a pull request in coronasafe/care_fe on July 11, 2022 at 7:37:13 AM
@nihal467 Done!
https://github.com/coronasafe/care_fe/pull/2614#issuecomment-1180066562
Shared a comment on an issue in coronasafe/care_fe on July 9, 2022 at 12:00:35 PM
@nihal467 It seems related to https://github.com/coronasafe/care_fe/pull/2946#issuecomment-1172863289 @gigincg Could you or anyone else having the Recaptcha admin account take a look into the Recaptcha Admin panel and check if `care.coronasafe.in` is added as an allowed domain and also make sure that the below sitekey is valid? The sitekey used is here: https://github.com/coronasafe/care_fe/blob/develop/src/Common/env.tsx#L1
https://github.com/coronasafe/care_fe/issues/3092#issuecomment-1179531451
Shared a comment on an issue in coronasafe/care on July 6, 2022 at 6:20:35 PM
@skks1212 added, ty :D
https://github.com/coronasafe/care/issues/911#issuecomment-1176535397
Shared a comment on a pull request in coronasafe/care on July 6, 2022 at 6:20:24 PM
Fixes #911
https://github.com/coronasafe/care/pull/841#issuecomment-1176535252
Shared a comment on an issue in coronasafe/care on July 5, 2022 at 2:40:00 PM
Related: https://github.com/coronasafe/care_fe/issues/2642 https://github.com/coronasafe/care_fe/pull/2659
https://github.com/coronasafe/care/issues/907#issuecomment-1175141137
Shared a comment on an issue in coronasafe/care_fe on July 5, 2022 at 2:39:26 PM
This is happening due to the "Last admitted to" filter. Related: https://github.com/coronasafe/care_fe/issues/2642
https://github.com/coronasafe/care_fe/issues/2981#issuecomment-1175140470
Shared a comment on an issue in coronasafe/care on July 5, 2022 at 2:35:38 PM
Seems related to https://github.com/coronasafe/care/pull/841/ The line causing the error is to be removed since `admitted_to` is no longer needed. https://github.com/coronasafe/care/pull/841/files#diff-1cfa8525a1bda136e828a93f18708d7aca15e41111ac3e0fbc9fc848a9a7a116L98
https://github.com/coronasafe/care/issues/911#issuecomment-1175136208
Shared a comment on a pull request in coronasafe/care_fe on July 2, 2022 at 8:49:13 AM
> ![10](https://user-images.githubusercontent.com/57055998/176993284-e57054c3-5a99-4094-b894-bd6939f1e3fc.jpg) > > @Ashesh3 captcha is not working The Recaptcha keys are for a specific domains only, The error stated in the screenshot explains itself. If they site-key permits itself to be used on the domain you are testing the site on, it would work, otherwise Recaptcha will fail to render. I tested it on localhost and it seems `localhost` is in allowed domains. This PR has nothing to do with the way Recaptcha renders, all it changes is just `src/Redux/fireRequest.tsx` to display the error before returning the response. The domain you are running this test on, needs to be added in the domains section of the google Recaptcha page where you generated the API key.
https://github.com/coronasafe/care_fe/pull/2946#issuecomment-1172863289
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 9:01:11 AM
> @Ashesh3 sorry about that, this issue was reported and wanted to be fixed urgent, so when I searched the issues, there was no issue regarding this error, so I kinda went a head and made a pr without searching if there was any pr related to this. 😅 > > It's my bad, just to be more careful for here on, I suggest creating an issue and assign it to yourself and move a head with pr. > > sorry again Ashesh. Oh I see, Yep this was indeed an important issue, I agree with you! Thank you for the tip, will create issues for my PRs 😄 And It's all good man! As long as the bugs are resolved, that's what we're here for, right 😉 ! Thanks again!
https://github.com/coronasafe/care_fe/pull/2715#issuecomment-1164145611
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 8:16:16 AM
@khavinshankar @gigincg Wait, i am a bit confused here.. Wasn't this PR opened before? 😅 It was opened, approved days ago but a newer PR ended up getting merged instead? Am i missing something here? 😅 Just wanna make sure my PRs aren't getting hidden behind. June 14 this PR and June 17 the other PR
https://github.com/coronasafe/care_fe/pull/2715#issuecomment-1164099784
Shared a comment on a pull request in coronasafe/care on June 22, 2022 at 6:30:47 AM
@vigneshhari Any updates on this? :D
https://github.com/coronasafe/care/pull/810#issuecomment-1162699434
Shared a comment on an issue in coronasafe/care_fe on June 21, 2022 at 6:32:30 AM
Seems duplicate of https://github.com/coronasafe/care_fe/pull/2715 (Created on June 14th)
https://github.com/coronasafe/care_fe/issues/2783#issuecomment-1161320841
Shared a comment on an issue in coronasafe/care_fe on June 21, 2022 at 6:32:30 AM
Seems duplicate of https://github.com/coronasafe/care_fe/pull/2715 (Created on June 14th)
https://github.com/coronasafe/care_fe/issues/2783#issuecomment-1161320841
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2022 at 8:23:25 AM
> Hey @Ashesh3! This issue has been already fixed in #2702 😅 Oh, alright! 😄 You can link the issue to that PR then!
https://github.com/coronasafe/care_fe/pull/2706#issuecomment-1154871486
Shared a comment on a pull request in coronasafe/care_fe on June 8, 2022 at 12:33:47 PM
> @Ashesh3 Can you make the Backend issues as well for this? Made it here: https://github.com/coronasafe/care/pull/838
https://github.com/coronasafe/care_fe/pull/2525#issuecomment-1149855806
Shared a comment on a pull request in coronasafe/care_fe on June 4, 2022 at 3:53:58 AM
> @Ashesh3 Can you make the Backend issues as well for this? Sure, On it!
https://github.com/coronasafe/care_fe/pull/2525#issuecomment-1146520998
Shared a comment on a pull request in coronasafe/care_fe on June 3, 2022 at 2:40:09 PM
I feel not all endpoints in `api.ts` need a trailing slash, and adding it in some cases will cause malfunction. For instance, Updating a Facility fails with this change. This is because of the way `fireRequest` works. ``` export const fireRequest = ( ... if (path.length > 0) { request.path += "/" + path.join("/"); } ... ``` Adding a trailing slash to `updateFacility` key in the `api.ts` would lead to the final URL being: `http://localhost:4000/api/v1/facility//4a3dbe9c-8d1b-4dc1-b939-237d79d96233` (Notice the double slash there). Which obviously errors out: ![image](https://user-images.githubusercontent.com/3626859/171876150-88ec6227-f2a8-4fcf-9d10-454821a13fdc.png) Some endpoints in `api.ts` are to be without end slashes for the above reason. I believe this issue would be resolved better with this PR: https://github.com/coronasafe/care_fe/pull/2395 This is because the mentioned PR modifies how `fireRequest` works and just adds a trailing slash on the fly whenever and only when its necessary.
https://github.com/coronasafe/care_fe/pull/2581#issuecomment-1146032939
Shared a comment on a pull request in coronasafe/care_fe on June 3, 2022 at 5:08:00 AM
@khavinshankar Done! thanks for the ping.
https://github.com/coronasafe/care_fe/pull/2442#issuecomment-1145588854
Shared a comment on a pull request in coronasafe/care_fe on May 27, 2022 at 7:30:24 PM
> @Ashesh3 @gigincg is it good for testing ? Yep, it is!
https://github.com/coronasafe/care_fe/pull/2525#issuecomment-1139967607
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2022 at 3:35:35 PM
Using `/\S+/` to check if the string is empty or not. ![image](https://user-images.githubusercontent.com/3626859/170520528-94489786-c65c-40cc-857e-a2fe9ee0a507.png)
https://github.com/coronasafe/care_fe/pull/2525#issuecomment-1138709480
Shared a comment on an issue in coronasafe/care_fe on May 26, 2022 at 12:10:49 PM
Now that's one smart way to hide your last seen! 👀
https://github.com/coronasafe/care_fe/issues/2535#issuecomment-1138497558
Shared a comment on an issue in coronasafe/care_fe on May 26, 2022 at 11:52:48 AM
> > I believe that the intention of displaying the message "Comment should contain at least 1 character" to the user is to prevent mishaps where they user might accidently try to hit the "Post comment"/"Add note" button without actually filling the box. > > Sure, they can still bypass it by adding a space. But if we then add a check for the space, we would need to address dozens other ways where the user might try to post an empty comment. For example, using empty Unicode characters or even unintentional characters like a single dot or multiple spaces, tabs etc. > > Although adding this is a neat little change, I think it might be out of scope of the behavior we are expecting from the check there currently is (Which is only checking length of the TextField's value). > > TLDR; There would be many ways to bypass this check and it's main purpose should be limited to just nudging the user in case they hit submit without any text, accidently. > > Just my thoughts, would love to hear other opinions on this! smile > > Yeah @Ashesh3 I completely agree on this but comment without anything looks a little unprofessional it can contain anything a dot or any single character but containing space can make it look empty :) Even in whatsapp try to send a message containing only spaces no character it would not allow you to send it. Having this check maybe a bit enhancement 😄 Yep, agree with you there, could be a neat enhancement! We would also need to add a check for invisible Unicode characters too, since that would let users post a blank (but non empty) comment. Bonus: Try copy pasting this character ` ` (select the code block and copy), into Whatsapp and see what happens 😉
https://github.com/coronasafe/care_fe/issues/2532#issuecomment-1138457947
Shared a comment on an issue in coronasafe/care_fe on May 26, 2022 at 11:32:00 AM
I believe that the intention of displaying the message "Comment should contain at least 1 character" to the user is to prevent mishaps where they user might accidently try to hit the "Post comment"/"Add note" button without actually filling the box. Sure, they can still bypass it by adding a space. But if we then add a check for the space, we would need to address dozens other ways where the user might try to post an empty comment. For example, using empty Unicode characters or even unintentional characters like a single dot or multiple spaces, tabs etc. Although adding this is a neat little change, I think it might be out of scope of the behavior we are expecting from the check there currently is (Which is only checking length of the TextField's value). TLDR; There would be many ways to bypass this check and it's main purpose should be limited to just nudging the user in case they hit submit without any text, accidently. Just my thoughts, would love to hear other opinions on this! 😄
https://github.com/coronasafe/care_fe/issues/2532#issuecomment-1138435255
Shared a comment on an issue in coronasafe/care_fe on May 19, 2022 at 12:05:44 PM
When the user denies the browser's microphone permission, The UI has no way of informing the user, instead it just continues recording. This needs to be fixed to inform the user about the same and not show "Recording" when there is no permission. ![image](https://user-images.githubusercontent.com/3626859/169289293-80a92721-cfeb-45f1-b65a-b782aa9f2ea8.png) Shows Recording even though I have denied it microphone permission.
https://github.com/coronasafe/care_fe/issues/2418#issuecomment-1131603863
Shared a comment on a pull request in coronasafe/care_fe on May 18, 2022 at 8:48:39 PM
Reduced the spacing ![image](https://user-images.githubusercontent.com/3626859/169153051-57a28d0a-aca9-4511-b726-c4a6ee6c17c4.png)
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1130530033
Shared a comment on an issue in coronasafe/care_fe on May 18, 2022 at 10:48:41 AM
The above also applies to other parts of the same page: ![image](https://user-images.githubusercontent.com/3626859/169021973-68157161-a5db-40f5-b271-5c5f1f8e617c.png)
https://github.com/coronasafe/care_fe/issues/2418#issuecomment-1129858207
Shared a comment on a pull request in coronasafe/care_fe on May 17, 2022 at 9:52:41 PM
All the elements are now aligned to the line below the blood group. ![image](https://user-images.githubusercontent.com/3626859/168916108-5bb11745-920d-445b-b032-4ffe1d530738.png)
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1129351524
Shared a comment on an issue in coronasafe/care_fe on May 17, 2022 at 9:03:21 PM
> @Ashesh3 tested on 15.4 works fine ![image](https://user-images.githubusercontent.com/42417893/168906614-ae6d7dde-7e58-47d9-ac39-29189eb4b4a9.png) That's helpful! I only have versions <15.3 to test on, Guess it works with 15.4+ . I guess in either case the attached PR would be helpful not only to prevent the unnecessary redirects, but also to add support for <15.3 Safari versions. Thanks for the additional info!
https://github.com/coronasafe/care_fe/issues/1060#issuecomment-1129315159
Shared a comment on a pull request in coronasafe/care_fe on May 17, 2022 at 6:48:05 PM
@gigincg Error keys are now title cased. Since we already use `lodash` , I just used the built-in functions for this change. We no longer need regex to replace the "_" with " ". ![image](https://user-images.githubusercontent.com/3626859/168886930-2575fa74-a956-46ec-bef0-d0882c38568f.png) ![image](https://user-images.githubusercontent.com/3626859/168886490-cddda095-ccbb-4480-a383-d3b1594f8e2a.png)
https://github.com/coronasafe/care_fe/pull/2309#issuecomment-1129204050
Shared a comment on an issue in coronasafe/care_fe on May 17, 2022 at 6:18:41 PM
@arpancodes Hey, I tested it on Safari 15.3 and it was not working, on redirects, the Auth header is omitted which leads to some API calls failing. Where did you test it? Are you sure you used a Safari browser? If so, which version? ![image](https://user-images.githubusercontent.com/3626859/168882769-6f1dd621-0944-4168-8340-b0daa005cc18.png) ![image](https://user-images.githubusercontent.com/3626859/168883039-307acfae-55bd-4846-96ee-17eac5ad14df.png)
https://github.com/coronasafe/care_fe/issues/1060#issuecomment-1129178187
Shared a comment on a pull request in coronasafe/care_fe on May 17, 2022 at 3:34:29 PM
> ![psajfojasf](https://user-images.githubusercontent.com/57055998/168846833-114760c8-196e-4a57-9a5d-f6584e94e526.jpg) > > @Ashesh3 the alignment of created, diagnosis, and verified by is off, when we compared to the top Fixed the alignment of the said elements. ![image](https://user-images.githubusercontent.com/3626859/168849734-e6e1fd04-93d0-42d3-8d82-06fb52802c87.png)
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1129019472
Shared a comment on a pull request in coronasafe/care_fe on May 17, 2022 at 2:28:59 PM
@nihal467 Fixed the left alignment, reduced the facility name font size, made it semi bold to match it more with the surrounding elements. ![image](https://user-images.githubusercontent.com/3626859/168834981-13034df9-ca39-49e0-878a-72318d84b0cb.png)
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1128943422
Shared a comment on a pull request in coronasafe/care_fe on May 16, 2022 at 5:46:50 AM
@nihal467 Fixed the alignment to match the padding of the patient name on the left side. - With inner padding on div `md:pl-2` (Updated in this PR) ![image](https://user-images.githubusercontent.com/3626859/168526664-cfe8044f-de58-4f7b-a519-e74a9eb8bf95.png) - Without inner padding (Not in this PR) ![image](https://user-images.githubusercontent.com/3626859/168526988-14165535-04bc-467b-96bd-4cf6426fa77c.png) Let me know which one works the best.
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1127244810
Shared a comment on a pull request in coronasafe/care_fe on May 16, 2022 at 5:20:59 AM
> ![wpojefeopf](https://user-images.githubusercontent.com/57055998/168523635-7be54252-a901-40f1-89fb-a50e9d6a56c3.jpg) > > @Ashesh3 @gigincg i can't see any update in the PR, That's correct, Just wanted to get a visual feedback first if that looks good or not. if yes, I'd add the updated commit to this PR! Did that just now!
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1127233036
Shared a comment on a pull request in coronasafe/care_fe on May 15, 2022 at 4:07:38 PM
@nihal467 Is this better? ![image](https://user-images.githubusercontent.com/3626859/168482478-268b881d-e7f1-44a4-b9a1-0f0757bae21a.png)
https://github.com/coronasafe/care_fe/pull/2304#issuecomment-1126970983
No progress today.
• PRs: <https://github.com/coronasafe/care_fe/pull/2442|#2442> <https://github.com/coronasafe/care_fe/pull/2433|#2433> • Created Issues: <https://github.com/coronasafe/care_fe/issues/2440|2440> <https://github.com/coronasafe/care_fe/issues/2418|#2418>
Submitted a PR, <https://github.com/coronasafe/care_fe/pull/2406> Took up an issue to work on
Made a PR: <https://github.com/coronasafe/care_fe/issues/1060>
No update, just picked up an issue to consider working on.
Haven't had any new updates on my side. I'm just resting down and waiting for my pull requests to get merged.
Submitted 3 more PRs to the care_fe repo, resolving issues. Submitted 1 PR to the care repo, requiring backend change.
Cloned and set up the `care_fe` repo locally successfully. Submitted my first PR resolving an issue.
Issues raised: <https://github.com/coronasafe/care_fe/issues/2507|#2507> <https://github.com/coronasafe/care_fe/issues/2505|#2505> PRs: <https://github.com/coronasafe/care/pull/789|care#789> <https://github.com/coronasafe/care/pull/788|care#788> <https://github.com/coronasafe/care_fe/pull/2536|#2536> <https://github.com/coronasafe/care_fe/pull/2525|#2525>
Worked on existing issues, now looking for new issues.
Started working on <https://github.com/coronasafe/care_fe/issues/2505|#2505>
Made two minor PRs, <https://github.com/coronasafe/care_fe/pull/2614|#2614> <https://github.com/coronasafe/care_fe/pull/2615|#2615>
Nothing for today, just college work.
Worked on issue <https://github.com/coronasafe/care_fe/issues/2643|#2643> PRs resolving the issue: <https://github.com/coronasafe/care_fe/pull/2645|#2645> <https://github.com/coronasafe/care/pull/815|#care/815>
Nothing for today, busy with college project.
Worked on <https://github.com/coronasafe/care/pull/838|#838>
Worked on an existing PR and took up a new issue.
Worked on PRs <https://github.com/coronasafe/care_fe/pull/2715|#2715> <https://github.com/coronasafe/care_fe/pull/2714|#2714> <https://github.com/coronasafe/care_fe/pull/2713|#2713>
Made PR <https://github.com/coronasafe/care_fe/pull/3511|#3511> and reviewed some PRs.
No big updates, took up a PR.
Worked on previous PR <https://github.com/coronasafe/care_fe/pull/3503|#3503>
Worked on <https://github.com/coronasafe/care/pull/998|#998>
Finished working on public asset page for care dashboard. Currently, the UI is consistent with `care_fe` .
Made PRs: <https://github.com/coronasafe/care_fe/pull/3568|#3568> <https://github.com/coronasafe/care_fe/pull/3569|#3569> <https://github.com/coronasafe/care_fe/pull/3570|#3570>
Couldn't do much today, travelling.
Made PRs: <https://github.com/coronasafe/care_fe/pull/3624|#3624> <https://github.com/coronasafe/care_fe/pull/3623|#3623>
Made PR <https://github.com/coronasafe/care_fe/pull/3631|#3631>
Made PR: <https://github.com/coronasafe/care_fe/pull/3639|#3639>
Made PR: <https://github.com/coronasafe/care_fe/pull/3645|#3645>
Made PR: <https://github.com/coronasafe/care_fe/pull/3654|#3654>
Made PR: <https://github.com/coronasafe/care_fe/pull/3660|#3660> and working on other issues.
Worked on: <https://github.com/coronasafe/care_fe/pull/3584#issuecomment-1261401459|#3584>
Made PR: <https://github.com/coronasafe/care_fe/pull/3667|#3667>
Made PR: <https://github.com/coronasafe/care_fe/pull/3688|#3688>
Made PR: <https://github.com/coronasafe/care_fe/pull/3699|#3699>
Made PR: <https://github.com/coronasafe/care/pull/1052|#1052>
Made PRs: <https://github.com/coronasafe/care_fe/pull/3717|#3717> <https://github.com/coronasafe/care_fe/pull/3718|#3718>
Finding new issues to work on.
Made PR: <https://github.com/coronasafe/care_fe/pull/3741|#3741>
Made PR: <https://github.com/coronasafe/care_fe/pull/3754|#3754>
Worked on previous PRs and made 2 issues.
Made PR: <https://github.com/coronasafe/care_fe/pull/3813|#3813>
Made PR: <https://github.com/coronasafe/care_fe/pull/3824|#3824>
Worked on: <https://github.com/coronasafe/care_fe/pull/3867|#3867>
EOD 21/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Fixed issues with autosave form not saving some fields (state,district) • Worked on two minor UI issues: #5732 #5736 • Explored GPT functions and studied their use case for Ayushma • Had an onboarding call with Shahid along with Rithvik and Aakash What's next? • Get started on monitoring Asset uptime
_EOD 28/06/2023_ <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Worked on issue <https://github.com/care_fe/issues/5797|#5797 - Mark file upload as complete for sample test> (needs testing, P1) • Worked on updating <https://github.com/care_fe/src/Components/Patient/PatientRegister.tsx|src/Components/Patient/PatientRegister.tsx> with Tailwind (cypress passed, needs testing) • Resolved issues in PR <https://github.com/care_fe/issues/5765|#5765 - Fix linting errors and add ventilator icon> (blocked, cypress passed, needs testing) What's next? • Work on implementing celery tasks for fetching asset uptime from middleware • Study about optimizing celery tasks and error handling
_EOD 30/06/2023_ <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Worked on fixing design issues with the Tailwind Patient Register page in the existing PR • Completed the implementation of the celery task to automatically fetch asset status from middleware What's next? • Waiting for more issues to be assigned
_EOD 01/07/2023_ <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* • Worked on PR <https://github.com/coronasafe/care_fe/pull/5814|#5814> - Clear location data when facility filter is removed (needs testing, P1) • Worked on PR <https://github.com/coronasafe/care_fe/pull/5813|#5813> - Remove default values for Manage Inventory page (needs testing) • Worked on PR <https://github.com/coronasafe/care_fe/pull/5810|#5810> - Fix icon alignment in Sample Test History (needs testing) • Merged PR <https://github.com/coronasafe/care_fe/pull/5808|#5808> - Reset HL7/Ventilator socket url when not available (P1, tested) • Merged PR <https://github.com/coronasafe/care/pull/1416|#1416> - Remove PII from Patient CSV export (waiting for review, P1, high priority, urgent) *What's next?* • Work on more pending PRs on Monday
_EOD 03/07/2023_ <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* • Worked on PR <https://github.com/coronasafe/care_fe/pull/5826|#5826> - Fix filter badges for Shifting and Resource (needs testing) • Merged PR <https://github.com/coronasafe/care_fe/pull/5822|#5822> - Fix incorrect type for csv export (tested) • Clean up some old code for asset uptime • Clear out some merge conflicts on older PRs *What's next?* • Explore syncing of Metabase instances
_EOD 04/07/2023_ <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Worked on Fixing the filter badges for Shifting and Resource • Made progress on the metabase sync project What's next? • Complete the frontend for the metabase sync project
*EOD 05/07/2023* <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* • Worked on the Metabase management app. What's *up next?* • Work on pending GitHub issues
*EOD 07/07/2023* <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* Worked on the following: • <https://github.com/coronasafe/care_fe/pull/5850|PR #5850>: Allow 10 digit number without country code. • <https://github.com/coronasafe/care_fe/pull/5844|PR #5844>: Update npm dependencies to resolve dependabot alerts. • *What's next?* Work on the following issues: • <https://github.com/coronasafe/care_fe/issues/5849|Issue #5849>: Alignment issue in asset configuration page. • <https://github.com/coronasafe/care_fe/issues/5845|Issue #5845>: Selected Emergency status field malfunctioning in resource update page. • Uninstall the `screenfull` package and use the `useFullscreen` custom hook instead.
EOD 08/07/2023 <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* Worked on the following: • <https://github.com/coronasafe/care_fe/pull/5857|PR #5857>: Replace `screenfull` package with `useFullscreen` hook. • <https://github.com/coronasafe/care_fe/pull/5856|PR #5856>: Fix emergency checkbox for Resource. • <https://github.com/coronasafe/care_fe/pull/5852|PR #5852>: Fix alignment of 'Preset Name'.
*EOD 11/07/2023* <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* • Made PR <https://github.com/coronasafe/ayushma/pull/204|ayushma#204>: Add per project model selection • Made PR <https://github.com/coronasafe/ayushma_fe/pull/60|ayushma_fe#60>: Add model selection to project page • Made PR <https://github.com/coronasafe/ayushma_fe/pull/59|ayushma_fe#59>: Add default ordering for project list • Made PR <https://github.com/coronasafe/care_fe/pull/5861|care_fe#5861>: Replace OnlineUsersSelect with Tailwind component • Made PR <https://github.com/coronasafe/care_fe/pull/5860|care_fe#5860>: Fix missing badges on Shifting filter *What's next?* • Work on issue <https://github.com/coronasafe/ayushma/issues/206|ayushma#206>: Add option to stop running test • Work on issue <https://github.com/coronasafe/care_fe/issues/5863|care_fe#5863>: CARE Landing page: add logos and website link • Work on issue <https://github.com/coronasafe/care_fe/issues/5859|care_fe#5859>: Pincode Auto-fill is not working properly for Sikkim & Assam pincode *Extra* • Worked on a side project, <https://github.com/Ashesh3/github-activity/> to help writing EOD messages :eyes: Deployed at <https://git-eod.vercel.app/>
*EOD 12/07/2023* <!subteam^S035L5S02RF|@care_engineering> *How did the day go?* • Created issue <https://github.com/coronasafe/metabase_manager/issues/1|metabase_manager#1>: SQL query based questions appear blank after copying. • Created issue <https://github.com/coronasafe/ayushma/issues/212|ayushma#212>: Random Test Failures Due to OpenAI Rate Limit • Comitted <https://github.com/coronasafe/metabase_manager/commit/4ec97915d42c7259d1f65471fe7be85eb0c40c6a|metabase_manager#4ec9791>: fix copying sql based questions Fixes #1 • Worked on resolving merge conflicts on existing PRs • Worked on fixing Tailwind conflicting class names • Worked on checking discrepancy for our state and district data *What's next?* • Work on issue <https://github.com/coronasafe/ayushma/issues/212|ayushma#212>: Random Test Failures Due to OpenAI Rate Limit
EOD 15/07/2023 <!subteam^S035L5S02RF|@care_engineering> how did the day go ? • Fixed rate limit issue with ayushma testing framework by implementing auto retries. • Made some frontend changes required for complying with the new asset uptime object • Worked on adding state management to metabase_manager, so next time it will remember which cards were synced to which ones exactly and carry out differential updates across instances.
*EOD 15/07/2023 - 22/07/2023* *How did the days go?* • Made PR <https://github.com/coronasafe/care_fe/pull/5896|care_fe#5896>: Fix asset uptime carryover • Made PR <https://github.com/coronasafe/care_fe/pull/5894|care_fe#5894>: Fix asset uptime for phases of day • Made PR <https://github.com/coronasafe/care/pull/1466|care#1466>: Mark asset as down when middleware is down • Made PR <https://github.com/coronasafe/care_deploy_configs/pull/17|care_deploy_configs#17>: Change logo keys for readibility • Made PR <https://github.com/coronasafe/care_fe/pull/5887|care_fe#5887>: Fix asset uptime status keys • Made PR <https://github.com/coronasafe/care_fe/pull/5886|care_fe#5886>: Replace care logo with 10bedicu logo • Made PR <https://github.com/coronasafe/care_fe/pull/5883|care_fe#5883>: Add 10bedicu logo to homepage • Made PR <https://github.com/coronasafe/ayushma_fe/pull/64|ayushma_fe#64>: Add option to export test results to CSV • Made PR <https://github.com/coronasafe/care_fe/pull/5879|care_fe#5879>: Add asset uptime *What's next?* • Work on issue <https://github.com/coronasafe/care_fe/issues/5895|care_fe#5895>: patient creation by External Result import is not working • Work on issue <https://github.com/coronasafe/ayushma_fe/issues/65|ayushma_fe#65>: Show average cosine and bleu scores in exported test runs in CSV.